Skip to content

[fix] deliver buffered data before EOF - #388

Merged
kares merged 1 commit into
jruby:masterfrom
segiddins:samuel.giddins/2026-10-14/deliver-buffered-data-before-eof
Oct 16, 2026
Merged

kares merged 1 commit into
jruby:masterfrom
segiddins:samuel.giddins/2026-10-14/deliver-buffered-data-before-eof

Conversation

@segiddins

Copy link
Copy Markdown
Contributor

This matches openssl and MRI's behavior -- some tls servers dont explicitly close, but most clients handle that because the HTTP atop it is framed separately and completed.

Fixes a regression in recent jruby openssl gem versions

See RFC 9110 §9.8

@kares kares self-assigned this Oct 15, 2026
@kares
kares merged commit dfe8d96 into jruby:master Oct 16, 2026
74 checks passed
@kares

kares commented Oct 16, 2026

Copy link
Copy Markdown
Member

Thanks, we have another issue to figure out and that can cut a release and bump the gem in jruby-head.

kares added a commit that referenced this pull request Oct 16, 2026
restore buffer modes before validating transport EOF so decrypted data
is delivered first and failed close leaves buffers in consistent state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants