Conversation
config() should not be callable from math.evaluate() expressions as it mutates the shared configuration singleton, affecting all subsequent evaluations on the same instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config()is currently registered inmath.expression.mathWithTransform, making it callable frommath.evaluate()expressions. This allows an expression to mutate the sharedconfigInternalsingleton (e.g.,relTol,absTol), corrupting comparison results (equal,compare,larger,smaller) for all subsequent evaluations on the same instance.The function is not listed in the security documentation's recommended blocklist (
docs/expressions/security.md), so applications following the official hardening guide remain vulnerable.This patch removes
configfrommathWithTransformso it is no longer accessible from expressions.math.config()from JavaScript continues to work as before.Reproduction
Test plan
math.evaluate('config()')throws "Undefined function config"math.config()from JS still worksequal,compare,larger,smallerare not affected