feat(usergroups): add missing team_id argument to usergroups.users.list - #191
feat(usergroups): add missing team_id argument to usergroups.users.list#191maartenpaauw wants to merge 2 commits into
Conversation
|
Hello, thank for you contribution, it looks good! I just updated the SDK on |
The `team_id` query parameter is documented by Slack as an optional
argument for `usergroups.users.list` ("The user group's encoded team ID.
Required if org token is used."), but it was absent from the patched
OpenAPI spec, so the generated endpoint rejected it with an
UndefinedOptionsException.
Add it to resources/slack-openapi-patched.json (matching the existing
team_id override on usergroups.list), refresh the community patch file,
and regenerate the affected endpoint code.
Ref: https://docs.slack.dev/reference/methods/usergroups.users.list
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CXAVNUu5y3nHkfzq2TdNfX
d6e23bd to
74f38e9
Compare
|
@damienalexandre thanks for the quick response! I've rebased my branch and it is up-to-date with main. |
|
Tests are not happy, you need to "composer update" and "vendor/bin/jane-openapi generate --config-file=.jane-openapi.php" I think. |
CI regenerates the SDK with the latest JanePHP (currently 7.14.0) and fails on any diff. Running `composer update` + `jane-openapi generate` picks up JanePHP 7.14, which reworks parts of the Runtime layer (FormEncoder/JsonPayload/JsonObject, additional-properties handling), drops CustomQueryResolver, and adds an `applyServerPlugins` flag to `Client::create()` that installs php-http host/path plugins from the OpenAPI server definition. `ClientFactory` already installs `AddSlackPathAndHostPlugin`, so it now opts out of those generated server plugins: their `AddPathPlugin` skips the `/api` prefix for the `api.test` endpoint (its path already starts with `/api`), which broke `ApiTest`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CXAVNUu5y3nHkfzq2TdNfX
|
Rebuilt with JanePHP 7.14 ( That version auto-adds php-http server plugins in
|
Why
Slack documents
team_idas an optional argument forusergroups.users.list:It's missing from the patched OpenAPI spec, so the generated endpoint rejects it:
usergroups.listalready carries this same override — this bringsusergroups.users.listin line.What
team_idquery parameter to/usergroups.users.listinresources/slack-openapi-patched.jsonresources/slack-openapi-sorted.patch(new hunk + cascaded hunk offsets, same shape as Add team_id support for 3 endpoints #140)generated/Endpoint/UsergroupsUsersList.php,generated/Client.phpdocblock)Verification
slack-openapi-sorted.jsonand reproducesslack-openapi-patched.jsonexactlygenerated/diff is limited to what a full Jane regen produces for this spec changeJsonSorterTestpasses (patched spec still correctly sorted)php-cs-fixer --dry-runcleanNote on
check-specA full
jane-openapi generatewith the current latest Jane also rewrites a large number of unrelatedNormalizer/BaseEndpointfiles (Jane template drift since the last full rebuild in #189). That churn is intentionally not included here so this PR stays scoped toteam_id. Ifcheck-specfails on that unrelated diff, it reflects the pre-existing Jane-version drift onmainrather than this change — happy to rebase once the SDK is rebuilt.