Repository navigation
fix: jolt-lang/time pin for jolt v0.8.25 - #6
Merged
Merged
Conversation
…e quotes in its namespace docstring; the old pin's unescaped "Mar" ended the docstring early, so jolt v0.8.25 refused the ns form and every jolt run build failed. markdown_test calls the private split-before-h2-headings through its var, as JVM Clojure requires (bb allowed the direct call)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On jolt v0.8.25 every
jolt run buildfailed: the pinned jolt-lang/time (abeee499) has a namespace docstring with unescaped quotes ("Mar", "Sat"), which ends the string early, and v0.8.25 refuses the resulting ns form. jolt-lang/time escaped them in 51de696f; this pins its current main (06dfc4e7, 27 commits ahead, no breaking changes for the engine).Checked: champaca's site builds under both
jolt run buildandbb buildand passes its docs/check-site.sh;bb test110 tests, 286 assertions, 0 failures. Also: markdown_test called the private split-before-h2-headings directly, which bb allows but JVM Clojure and jolt refuse; it now calls it through its var.Not fixed here:
jolt teststill stops on cheshire, which bb has built in and jolt doesn't.