Add Python 3.14/3.14t support and Cython 3.3 - #1
Merged
Merged
Conversation
Mark the extension free-threading compatible (one SequenceMatcher per thread). Co-authored-by: Cursor <cursoragent@cursor.com>
cibuildwheel 4.2.1 rejects cpython-freethreading; 3.14t is default and pypy-eol keeps pp39/pp310. Co-authored-by: Cursor <cursoragent@cursor.com>
zip(strict=True) is 3.10-only; Pyodide cannot start threads; and cross-built ARM64 wheels cannot vendor the x64 MSVC CRT from the runner. Co-authored-by: Cursor <cursoragent@cursor.com>
…default. Co-authored-by: Cursor <cursoragent@cursor.com>
jlevy
changed the title
jlevy
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the missing dynamic-version regex and enable cibuildwheel free-threading for cp314t builds.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds Python 3.14/3.14t support, upgrades Cython, and improves free-threading documentation and testing.
Changes:
- Updates build metadata, CMake compatibility, and wheel CI.
- Adds concurrency support, locking, and tests.
- Adds local development configuration and documentation.
| File | Summary |
|---|---|
uv.toml |
Adds local uv configuration. |
uv.lock |
Adds development dependency lockfile. |
tools/sdist.patch |
Updates the sdist build patch. |
tests/test_concurrency.py |
Adds concurrency and free-threading tests. |
src/cydifflib/_initialize.pyx |
Adds free-threading compatibility and locking. |
README.md |
Documents development and concurrency behavior. |
pyproject.toml |
Updates build metadata and Python support. |
CMakeLists.txt |
Updates CMake compatibility. |
CLAUDE.md |
References contributor instructions. |
CHANGELOG.md |
Documents the unreleased changes. |
AGENTS.md |
Adds contributor build guidance. |
.gitignore |
Ignores local build artifacts. |
.github/workflows/build.yml |
Updates CI tooling and wheel targets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+59
to
62
| [[tool.dynamic-metadata]] | ||
| provider = "scikit_build_core.metadata.regex" | ||
| field = "version" | ||
| input = "src/cydifflib/__init__.py" |
Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a4f0cc63-a97a-4c93-a42e-5aa8a571c3a8) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Already in place and unchanged:
difflib, with no runtime dependenciestools/sdist.patchThis PR adds 3.14 and free-threaded 3.14t support and the Cython / concurrency work those builds require.
Problem
>=3.0.12,<3.1.0. 3.14t does not compile on Cython 3.0.x.# cython: freethreading_compatible=True, so a 3.14t import re-enables the GIL.SequenceMatcherscratch is per-instance; sharing one matcher across threads is unsupported (same as stdlib).HtmlDiff._default_prefixis process-wide.Changes
>=3.3.0,<3.4(build-only); scikit-build-core>=1.0; CMake max 3.30.freethreading_compatible=Truepragma;HtmlDiff._default_prefixlock; docs;tests/test_concurrency.py.zipwithoutstrict=, skip thread tests when threads cannot start, Windows ARM64 delvewheel exclude MSVC CRT); Intel Mac CI uses macos-15-intel because macos-13 runners are retired.uv.toml/uv.lock); no.python-version;AGENTS.mdis contributor docs only.Compatibility
Dependencies
build-system.requires).pytest>=8.Test plan