Skip to content

JITSU-48: rename the Helm chart from jitsu-dev to jitsu - #1517

Open
sahiltyagi-jitsu wants to merge 1 commit into
newjitsufrom
chore/jitsu-48-rename-helm-chart
Open

sahiltyagi-jitsu wants to merge 1 commit into
newjitsufrom
chore/jitsu-48-rename-helm-chart

Conversation

@sahiltyagi-jitsu

Copy link
Copy Markdown
Contributor

JITSU-48 asks whether the chart should keep the jitsu-dev identity now that it is what self-hosters are pointed at. Ildar's answer on the thread was one word: rename.

Split out from the prod-mode work (#NEXT) so a naming decision is reviewable on its own rather than buried in ~600 lines of templating.

What changed

Chart.yaml name and description, the jitsu-dev.* template helpers → jitsu.*, and the two sentences of prose that called it "the development Helm chart".

Everything else in the diff is the helper prefix.

Why jitsu

Ildar's own precedent, not a preference of mine. He created jitsu-dev in Feb 2026 (26fcf6665). In July he extracted the dependencies into a sibling chart and named it jitsu-deps — not jitsu-deps-dev — in ee0d3a8b4, even though that chart is equally dev-only. git log -p shows jitsu-deps is the only name it has ever had.

Three further confirmations in-repo: RELEASE_NAME already defaults to jitsu (dev-deploy.sh:13), the common labels already emit app.kubernetes.io/part-of: jitsu, and the sibling release is jitsu-deps.

Nothing external depends on the old name

Verified: no workflow under .github/ mentions helm at all; there is no helm package, helm push, chart-releaser, index.yaml or chart repository anywhere in the repo. The chart is consumed one way — clone and run helm/dev-deploy.sh, which passes CHART_DIR="$SCRIPT_DIR", a path, never a chart name.

So there is no published artifact to rename and no consumer pinning jitsu-dev.

It cannot break an existing install

Helm keys a release on the release name, not the chart name.

Rendered output, before vs after: the only differences are # Source: comments and the helm.sh/chart label. Resource names and app.kubernetes.io/name selector labels are byte-identical (md5 match) — the templates hardcode name: console etc. and never derive names from the chart, so the immutable-selector failure a rename usually risks does not apply.

Confirmed against a live cluster, not just the diff: helm upgrade took a Minikube release from jitsu-dev-0.1.0 (revision 6) to jitsu-0.1.0 (revision 7) with no resource recreated. Only console and operator rolled new pods — the two whose pod templates genuinely changed in later commits; the other five kept pods that were 3d22h old.

Deliberately not included

  • appVersion: "dev" — read by nothing (it appears twice in the repo, once per Chart.yaml, referenced by no template, label or workflow), and helm-deps carries the same value, so changing one alone creates a fresh inconsistency. Giving the chart a real version implies a release process that does not exist.
  • CHANGES.md still says "development Helm chart" in three places. It is a changelog describing a past release; rewriting history there would be wrong.

Scope note

Two other matches for jitsu-dev in the repo are unrelated and untouched: jitsu-dev-network in docker/docker-compose.yml is a Docker network name, and the three in helm-deps/values.yaml are dev passwords. A repo-wide rename would have changed both.

🤖 Generated with Claude Code

JITSU-48 asks whether the chart should keep the `jitsu-dev` identity now that
the public docs already point self-hosters at it. Ildar's answer was "rename".

Renames the chart and the `jitsu-dev.*` template helpers to `jitsu.*`, matching
the release name (`RELEASE_NAME` already defaults to `jitsu`), the sibling
`jitsu-deps` chart, and the existing `app.kubernetes.io/part-of: jitsu` label.

Scope is deliberately limited to `helm/`. Two other matches for `jitsu-dev` in
the repo are unrelated and untouched: `jitsu-dev-network` in
docker/docker-compose.yml is a Docker network name, and the three in
helm-deps/values.yaml are dev passwords.

Rendered output is unchanged apart from the `helm.sh/chart` label and `# Source:`
comments — verified by diffing `helm template` before and after. Resource names
and `app.kubernetes.io/name` selector labels are byte-identical, so existing
installs upgrade without hitting immutable-field errors.

The README title drops "Dev", but the body now states plainly that the chart is
still Minikube-only and should not go to a shared cluster until JITSU-48's
production mode lands. `appVersion: "dev"` is left alone — that is a release
versioning decision, not part of the rename.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the Helm chart identity and helper rename, including rendered manifests and upgrade-sensitive labels/selectors. No actionable findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant