JITSU-48: rename the Helm chart from jitsu-dev to jitsu - #1517
Open
sahiltyagi-jitsu wants to merge 1 commit into
Open
sahiltyagi-jitsu wants to merge 1 commit into
sahiltyagi-jitsu wants to merge 1 commit into
Conversation
JITSU-48 asks whether the chart should keep the `jitsu-dev` identity now that the public docs already point self-hosters at it. Ildar's answer was "rename". Renames the chart and the `jitsu-dev.*` template helpers to `jitsu.*`, matching the release name (`RELEASE_NAME` already defaults to `jitsu`), the sibling `jitsu-deps` chart, and the existing `app.kubernetes.io/part-of: jitsu` label. Scope is deliberately limited to `helm/`. Two other matches for `jitsu-dev` in the repo are unrelated and untouched: `jitsu-dev-network` in docker/docker-compose.yml is a Docker network name, and the three in helm-deps/values.yaml are dev passwords. Rendered output is unchanged apart from the `helm.sh/chart` label and `# Source:` comments — verified by diffing `helm template` before and after. Resource names and `app.kubernetes.io/name` selector labels are byte-identical, so existing installs upgrade without hitting immutable-field errors. The README title drops "Dev", but the body now states plainly that the chart is still Minikube-only and should not go to a shared cluster until JITSU-48's production mode lands. `appVersion: "dev"` is left alone — that is a release versioning decision, not part of the rename. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JITSU-48asks whether the chart should keep thejitsu-devidentity now that it is what self-hosters are pointed at. Ildar's answer on the thread was one word: rename.Split out from the prod-mode work (#NEXT) so a naming decision is reviewable on its own rather than buried in ~600 lines of templating.
What changed
Chart.yamlname and description, thejitsu-dev.*template helpers →jitsu.*, and the two sentences of prose that called it "the development Helm chart".Everything else in the diff is the helper prefix.
Why
jitsuIldar's own precedent, not a preference of mine. He created
jitsu-devin Feb 2026 (26fcf6665). In July he extracted the dependencies into a sibling chart and named itjitsu-deps— notjitsu-deps-dev— inee0d3a8b4, even though that chart is equally dev-only.git log -pshowsjitsu-depsis the only name it has ever had.Three further confirmations in-repo:
RELEASE_NAMEalready defaults tojitsu(dev-deploy.sh:13), the common labels already emitapp.kubernetes.io/part-of: jitsu, and the sibling release isjitsu-deps.Nothing external depends on the old name
Verified: no workflow under
.github/mentions helm at all; there is nohelm package,helm push, chart-releaser,index.yamlor chart repository anywhere in the repo. The chart is consumed one way — clone and runhelm/dev-deploy.sh, which passesCHART_DIR="$SCRIPT_DIR", a path, never a chart name.So there is no published artifact to rename and no consumer pinning
jitsu-dev.It cannot break an existing install
Helm keys a release on the release name, not the chart name.
Rendered output, before vs after: the only differences are
# Source:comments and thehelm.sh/chartlabel. Resource names andapp.kubernetes.io/nameselector labels are byte-identical (md5 match) — the templates hardcodename: consoleetc. and never derive names from the chart, so the immutable-selector failure a rename usually risks does not apply.Confirmed against a live cluster, not just the diff:
helm upgradetook a Minikube release fromjitsu-dev-0.1.0(revision 6) tojitsu-0.1.0(revision 7) with no resource recreated. Only console and operator rolled new pods — the two whose pod templates genuinely changed in later commits; the other five kept pods that were 3d22h old.Deliberately not included
appVersion: "dev"— read by nothing (it appears twice in the repo, once perChart.yaml, referenced by no template, label or workflow), andhelm-depscarries the same value, so changing one alone creates a fresh inconsistency. Giving the chart a real version implies a release process that does not exist.CHANGES.mdstill says "development Helm chart" in three places. It is a changelog describing a past release; rewriting history there would be wrong.Scope note
Two other matches for
jitsu-devin the repo are unrelated and untouched:jitsu-dev-networkindocker/docker-compose.ymlis a Docker network name, and the three inhelm-deps/values.yamlare dev passwords. A repo-wide rename would have changed both.🤖 Generated with Claude Code