Skip to content

Give ntConstant an end position - #11

Open
partouf wants to merge 1 commit into
jimmckeeth:mainfrom
GDKsoftware:fix/const-end-position
Open

Give ntConstant an end position#11
partouf wants to merge 1 commit into
jimmckeeth:mainfrom
GDKsoftware:fix/const-end-position

Conversation

@partouf

@partouf partouf commented Aug 31, 2026

Copy link
Copy Markdown

A constant declaration produced a node with no end position at all, so a consumer working in line ranges could not tell how far the declaration reached. That silently truncates any constant whose value spans lines:

const
Banner = 'first part ' +
'second part';

reported only the first line, and a tool slicing that range dropped the continuation.

ntConstant was built with FStack.Push, so it was a plain TSyntaxNode with nowhere to record an end. Two changes are needed, because the node the caller finally sees is not the node that was parsed:

ConstantDeclaration now pushes a compound node and records its end, the
same way TypeDeclaration already does. This gives the intermediate
ConstList an accurate extent.

ConstSection rebuilds each constant from that ConstList, so it also has
to push a compound node and inherit the end from it. The start still
comes from the name, which is what a caller looking for the constant
expects; only the end is new.

TCompoundSyntaxNode.AssignEndPositionFrom is the counterpart to the existing AssignPositionFrom, for exactly this rebuild case.

Single-line constants keep ending on their own line - the new test asserts both directions, since an end that ran on to the next declaration would be no more useful than one that stopped short.

Verified against the existing suite: 42 passing, with the one pre-existing Serialization.BinaryRoundTrip failure unchanged (line_seq holds a pointer value that does not survive a round trip, unrelated to this change).

A constant declaration produced a node with no end position at all, so a
consumer working in line ranges could not tell how far the declaration
reached. That silently truncates any constant whose value spans lines:

  const
    Banner = 'first part ' +
             'second part';

reported only the first line, and a tool slicing that range dropped the
continuation.

ntConstant was built with FStack.Push, so it was a plain TSyntaxNode with
nowhere to record an end. Two changes are needed, because the node the
caller finally sees is not the node that was parsed:

  ConstantDeclaration now pushes a compound node and records its end, the
  same way TypeDeclaration already does. This gives the intermediate
  ConstList an accurate extent.

  ConstSection rebuilds each constant from that ConstList, so it also has
  to push a compound node and inherit the end from it. The start still
  comes from the name, which is what a caller looking for the constant
  expects; only the end is new.

TCompoundSyntaxNode.AssignEndPositionFrom is the counterpart to the
existing AssignPositionFrom, for exactly this rebuild case.

Single-line constants keep ending on their own line - the new test asserts
both directions, since an end that ran on to the next declaration would be
no more useful than one that stopped short.

Verified against the existing suite: 42 passing, with the one pre-existing
Serialization.BinaryRoundTrip failure unchanged (line_seq holds a pointer
value that does not survive a round trip, unrelated to this change).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant