Repository navigation
chore: drop debug logs and the unused weather build arg; 400 on a bad settings search - #297
Merged
Merged
Conversation
… settings search - AdminPanel's profile picture upload logged the file's name, size and type and the upload response; ChoreWidget logged the username and picture path on every failed avatar load, which repeats on an always-on display. Both removed, with the now unused uploadingPicture string. Errors still log. - client/Dockerfile still declared VITE_OPENWEATHER_API_KEY as a build arg and env var. Nothing reads it since weather moved server-side, and the docs called it unused. Removed from the Dockerfile and from the setup docs, so a client-side key isn't invited back. - POST /api/settings/search wraps a non-array body in an array and calls replaceAll on each key, so a number, an object or no body threw and answered 500. It now answers 400 unless every key is a string. The server's "=== SEARCHING SETTINGS ===" line stays: secretsInLogs.test.js uses it to show the route's logging was captured.
1 of 6 tasks
jherforth
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining items from mrramam#74.
uploadingPicturestring. Errors still log.client/Dockerfilestill declaredVITE_OPENWEATHER_API_KEY. Nothing reads it since weather moved server-side, andconfiguration.mdalready called it unused. It's removed from the Dockerfile,CONTRIBUTING.md,getting-started.md,configuration.mdandfrontend.md, so a client-side key isn't invited back.POST /api/settings/searchwraps a non-array body in an array and callsreplaceAllon each key, so a number, an object or no body threw and answered 500. It now answers 400 unless every key is a string. There's a new case inapiEndpoints.test.js, which fails without the check.The server's
=== SEARCHING SETTINGS ===line stays, becausesecretsInLogs.test.jsuses it to show the route's logging was captured.Server and client suites,
check:i18nand the client build pass.