Repository navigation
fix(chores): the 7-day row gets its own line, so the done button stays fully in card - #293
Merged
Merged
Conversation
…s in the card Beside the done button, seven marks need about 110 px, and a chore card in a narrow column has about 120 px for both. The marks pushed the button 11 px past the card's edge. The row now wraps onto its own line under the title and the button, with the card's full width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #292.
With the ⭐ row on, the done button stuck out past the right edge of a chore card in a narrow column. The card has about 120 px for its content, and the seven marks (about 110 px) shared a line with the 32 px button, so the marks pushed the button 11 px outside the card.
The row now wraps onto its own line under the title and the button, using the card's full width (
flexWrap: 'wrap'on the card,flexBasis: '100%'on the row). Nothing changes with the row off.Measured in Chrome at 1280 and 1024 px: the button sits 13 px inside the card's edge with the row on or off, and no card scrolls sideways. The client suite passes.