Repository navigation
fix(admin): a Save refused for a missing tab shows where the tab name must be entered - #289
Merged
Merged
Conversation
Enabling a widget or plugin without choosing a tab makes Save refuse, with the reason at the top of Admin. On a phone that is off screen, as is the field to fix, so Save seemed to do nothing and nothing was saved. Save now scrolls to the first widget or plugin missing a tab and puts the cursor in its tab picker, which already shows the requirement in red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling a widget or plugin without choosing a tab makes Save refuse, with the reason at the top of Admin. On a phone, both the message and the field to fix are off screen, so Save seems to do nothing and nothing is saved.
Save now scrolls to the first widget or plugin missing a tab and puts the cursor in its tab picker, which already shows the requirement in red. Covers the widgets card, Weather and plugins.
Tested on a phone-size screen with 7 plugins: before, the picker stayed off screen after Save; after, it is on screen and focused.