Skip to content

docs: clarify timeout units are milliseconds - #454

Closed
amarkdotdev wants to merge 1 commit into
jfrog:masterfrom
amarkdotdev:docs/timeout-units-ms
Closed

docs: clarify timeout units are milliseconds#454
amarkdotdev wants to merge 1 commit into
jfrog:masterfrom
amarkdotdev:docs/timeout-units-ms

Conversation

@amarkdotdev

@amarkdotdev amarkdotdev commented Aug 18, 2026

Copy link
Copy Markdown

Summary

  • Document that ArtifactoryClientBuilder connection/socket timeouts are in milliseconds (Apache HttpClient 4.x).
  • Same clarification on HttpBuilderBase methods that feed RequestConfig.

Fixes #450

Test plan

  • Docs-only change; no behavioral tests required
  • Skim Javadoc on setters/getters for clarity

@amarkdotdev
docs: clarify connection/socket timeout units are milliseconds
4dc0c8a 
Document that ArtifactoryClientBuilder and HttpBuilder timeouts use
milliseconds, matching Apache HttpClient 4.x RequestConfig.

Fixes jfrog#450

Signed-off-by: Aaron Mark <amark@g.jct.ac.il>
@amarkdotdev
amarkdotdev marked this pull request as ready for review August 18, 2026 19:08
@amarkdotdev

amarkdotdev commented Sep 7, 2026

Copy link
Copy Markdown
Author

Quick bump — still green on my side and happy to adjust if anything's needed. No rush, just checking if this is still on the radar.

@amarkdotdev

amarkdotdev commented Sep 7, 2026

Copy link
Copy Markdown
Author

Closing this PR. Thanks for the review time.

@amarkdotdev amarkdotdev closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Timeout unit not specified

1 participant

@amarkdotdev