Repository navigation
Conversation
….12)
`model: PHOENIX` in the SED file selects bolometric-correction tables built
from the PHOENIX-ACES atmospheres (Husser et al. 2013); NextGen stays the
default until the two are compared on the shipped examples (a follow-up,
once the tables are published).
Generator: generate_PHOENIX_LD_Tables.py gains `--products bc`. One stream
of the archive writes the limb-darkening tables, the BC tables in the
NextGen format (PHOENIX/BCs/{FACILITY}.bc.parquet) and their magnitude-
system record, and keeps the unnormalized band fluxes and the bolometric
flux per node in the intensities intermediate. The band flux is
2 pi int I_band(mu) mu dmu of the same band intensities the limb darkening
is fitted to. The bolometric term is the model's OWN bolometric flux (the
archive's flux spectrum of the node, 500 A - 5.5 um plus a Rayleigh-Jeans
tail), not sigma Teff^4: a PHOENIX flux is given at the model's outer
radius, 0.78 sigma Teff^4 at (4000 K, logg 0.5), and with that term the
PHOENIX BCs agree with MIST's where sigma Teff^4 would put them 0.1-0.3
mag off for giants. Coverage: GALEX through 2MASS Ks; WISE, Spitzer IRAC
and Johnson M get no column.
SED: the model name is resolved once and is case-sensitive; bc_grid
dispatches the published-table fetch per model (PUBLISHED_BC_MODELS); a
filter outside a model's coverage is refused quoting the grid yaml's
coverage sentence and naming `model: NextGen`; the draft names the
PHOENIX atmospheres; the figure keeps the NextGen spectra with their own
grid description.
Zenodo: record `phoenix_bc_tables` is registered as PENDING (new
zenodo_assets.PENDING, RecordPendingError) and ON_DEMAND; models/PHOENIX/
bc_tables.py fetches it with the NextGen tables' rules once pinned, and
says how to proceed until then. scripts/build_phoenix_bc.job is the
cluster run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AWjnwpYHm56hSpKBzbPhrG
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds PHOENIX-ACES (Husser et al. 2013) bolometric-correction tables as an alternative SED model, selected with
model: PHOENIXin the SED file. NextGen stays the default. Review item 8.9.12: the SED could only use NextGen because the BC tables predated the PHOENIX limb-darkening pipeline. That pipeline already streams the PHOENIX archive through the same filter profiles, weighting and extinction law, so the BC tables come from the same stream.Why PHOENIX is worth having:
ld_source: phoenixa star's flux and its limb darkening come from one atmosphere;Generator (
models/PHOENIX/generate_PHOENIX_LD_Tables.py --products bc)One stream of the archive now writes the limb-darkening tables, the BC tables and the BC magnitude-system record. The BC tables use the NextGen format (
PHOENIX/BCs/{FACILITY}.bc.parquet). The per-node unnormalized band fluxes and bolometric flux go into the intensities intermediate, so the BCs can be re-derived later without the archive.Band flux. The flux is 2 pi int I_band(mu) mu dmu, computed from the same band intensities the limb darkening is fitted to. The filters,
DetectorTypeweighting, extinction law and Vega zeropoints are NextGen's. As a result,PHOENIX.magsys.csvmatchesNextGen.magsys.csvrow for row.Bolometric term: the model's own bolometric flux, not sigma Teff^4. I measured this on 2026-11-18. A PHOENIX flux (and a BT-NextGen one) is given at the model's outer radius, so integrated over 500 A - 5.5 um it falls well short of sigma Teff^4 for low gravities:
A Planck curve puts only 1-2% of the flux past 5.5 um, so the gap is not missing infrared. Only the ratio of band flux to bolometric flux at one radius is physical. The BC therefore divides by the model's own integral, taken from the archive's flux spectrum of the same node (500 A - 5.5 um plus a Rayleigh-Jeans tail of 0.1-3%). That spectrum equals the intensities' 2 pi int I mu dmu to 1e-4 at the six nodes checked.
Coverage. The intensities stop at 2.6 um. A filter gets a column only if at least 99% of its weighted bandpass lies inside that range. That covers every NextGen column from GALEX through 2MASS Ks. WISE W1-W4, Spitzer IRAC 3.6 and Johnson M get no PHOENIX column.
Holes. Interior holes are filled by interpolating the BCs linearly along Teff, recorded in
meta["padding"].Subset check (tiny grid, [Fe/H] = 0, run locally against the archive)
BC differences in magnitudes. MIST BCs (ATLAS, normalized to sigma Teff^4) are taken from EXOFASTv2's tables at the same nodes.
At the two giant nodes, PHOENIX with its own bolometric flux agrees with MIST to 0.005-0.10 mag. The published NextGen tables divide by sigma Teff^4, and the BT-NextGen spectra integrate to 0.77 sigma Teff^4 at (4000, 0.5) and 0.94 at (4800, 2.5). So at the nodes checked, the NextGen BCs of giants look too negative: ~0.3 mag at logg 0.5, ~0.07-0.1 mag at logg 2-2.5. This PR leaves NextGen alone; it is the first thing the follow-up NextGen-vs-PHOENIX comparison has to look at.
SED side
model:key is the one spelling, and it is case-sensitive.phoenixraises namingPHOENIX. A name with no published tables raises unless an explicitmodel_root:holds that tree.bc_grid.PUBLISHED_BC_MODELSdispatches the published-table fetch per model.models/PHOENIX/bc_tables.pyfollows the NextGen fetch rules: per facility, md5-pinned, a local edit never overwritten, andexozippy-fetch-phoenix-bc-tablesfor offline use..sedrow in that filter, or a band whose flux something reads, raises at the grid build. The error quotes the coverage (coverage:inPHOENIX/BCs/PHOENIX.grid.yaml) and names the way out (drop the row, or usemodel: NextGen);\citep{Husser:2013}).The Zenodo record does not exist yet
The full table generation (~7000 nodes, 32 workers, about an hour) runs on the cluster (
scripts/build_phoenix_bc.job), not here. Until then the recordphoenix_bc_tablesis registered as PENDING (newzenodo_assets.PENDING/RecordPendingError) and as ON_DEMAND, so neither CI nor the test prewarm fetches it.While it is pending,
model: PHOENIXunder the default root fails at construction and names both ways out: NextGen, or locally generated tables throughmodel_root:. Publishing takes three steps:scripts/zenodo_publish.py pin --name phoenix_bc_tables --update-registry;A test fails while a name is in both RECORDS and PENDING.
Not in this PR
Tests
tests/test_phoenix_bc.pyuses synthetic intensities, a synthetic flux spectrum, a fake published record whose "download" is a local copy, and a synthetic PHOENIX tree undermodel_root:. Nothing touches the network or the archive. It covers:model: PHOENIXreading the PHOENIX grid;PHOENIX.magsys.csvis NextGen's minus the six uncovered columns.The existing PHOENIX-LD, Zenodo, BC-synthesis, band-filter and model-root suites pass unchanged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AWjnwpYHm56hSpKBzbPhrG