Skip to content

Complete packed search width coverage - #23

Merged
jcfangc merged 1 commit into
mainfrom
refactor/search-foundation
Oct 25, 2026
Merged

jcfangc merged 1 commit into
mainfrom
refactor/search-foundation

Conversation

@jcfangc

@jcfangc jcfangc commented Oct 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add Packed search cross-word property coverage for BITS=4, 5, and 6.
  • Extend the shared slice oracle to verify both PackedStr and PackedString for find, rfind, and contains.
  • Keep this foundation change test-only; production search behavior and API are unchanged.

Validation

  • cargo fmt --check
  • cargo check --workspace --benches
  • TMPDIR=/home/juncheng/projects/bit-string/target/tmp cargo test --workspace
  • RUSTFLAGS='-C target-cpu=native' TMPDIR=/home/juncheng/projects/bit-string/target/tmp cargo test -p bit-string --lib

All passed. The local temp directory was used because /tmp ran out of space during derive fixture builds.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-25T03:37:11.506690Z 76a3eb4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Oct 25, 2026

Copy link
Copy Markdown

Too many benchmarks in a single upload

The performance report could not be generated because there were too many benchmarks in a single upload. We recommend sharding your benchmarks into smaller uploads. See the documentation for more information.

@jcfangc
jcfangc merged commit bcaec5b into main Oct 25, 2026
6 of 7 checks passed
@jcfangc
jcfangc deleted the refactor/search-foundation branch October 25, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants