Skip to content

Test/packed string unit coverage - #20

Merged
jcfangc merged 103 commits into
mainfrom
test/packed-string-unit-coverage
Sep 6, 2026
Merged

jcfangc merged 103 commits into
mainfrom
test/packed-string-unit-coverage

Conversation

@jcfangc

@jcfangc jcfangc commented Sep 6, 2026

Copy link
Copy Markdown
Owner

No description provided.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 93.75000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...d_str/impls_for_conversion/tests_for_conversion.rs 84.61% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Sep 6, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 12.57%

⚡ 1 improved benchmark
✅ 226 untouched benchmarks
⏩ 210 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ strip_prefix/len_65536/miss/ours_string 522.5 ns 464.2 ns +12.57%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing test/packed-string-unit-coverage (aaa188a) with main (241871a)

Open in CodSpeed

Footnotes

  1. 210 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@jcfangc
jcfangc merged commit 4e3b6b7 into main Sep 6, 2026
7 checks passed
@jcfangc
jcfangc deleted the test/packed-string-unit-coverage branch September 6, 2026 01:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aaa188a49e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +219 to +220
let lockfile = Command::new("cargo")
.args(["generate-lockfile", "--offline", "--manifest-path"])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid requiring a pre-populated Cargo cache

On a clean machine running cargo test -p bit-string-derive, the outer build only fetches the derive crate's dependency graph, while this temporary fixture depends on the workspace root and additionally needs crates such as int-intervals and witnessed. Because cargo generate-lockfile --help defines --offline as running without network access, this command cannot resolve those uncached dependencies and the otherwise valid unit test fails before exercising the macro; the same issue affects the second fixture below. Allow Cargo to fetch the fixture dependencies or explicitly populate an isolated cache first.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants