Repository navigation
Test/packed string unit coverage - #20
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Merging this PR will improve performance by 12.57%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaa188a49e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let lockfile = Command::new("cargo") | ||
| .args(["generate-lockfile", "--offline", "--manifest-path"]) |
There was a problem hiding this comment.
Avoid requiring a pre-populated Cargo cache
On a clean machine running cargo test -p bit-string-derive, the outer build only fetches the derive crate's dependency graph, while this temporary fixture depends on the workspace root and additionally needs crates such as int-intervals and witnessed. Because cargo generate-lockfile --help defines --offline as running without network access, this command cannot resolve those uncached dependencies and the otherwise valid unit test fails before exercising the macro; the same issue affects the second fixture below. Allow Cargo to fetch the fixture dependencies or explicitly populate an isolated cache first.
Useful? React with 👍 / 👎.
No description provided.