Skip to content

docs(skills): local-ci owns verification, github-prs only PR mechanics - #152

Merged
jayleaton merged 1 commit into
mainfrom
chore/local-ci-skill
Nov 17, 2026
Merged

jayleaton merged 1 commit into
mainfrom
chore/local-ci-skill

Conversation

@jayleaton

@jayleaton jayleaton commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Rules. Before merge, run what this change needs on its exact head (make check-pr runs it): for Go, make lint test scoped with LINT_DIRS/TEST_PKGS (scripts/affected.sh prints them) or make check-fast, plus the checks of what you touched. Then make ci-local RAN="<what you ran>" posts local-ci and fills "Local verification" with that statement and the head SHA. Never edit that section by hand. The Local verification check, make pr-merge and the staging gate refuse the PR while it is missing, names another head, or differs from what local-ci attested. A new push or rebase needs a new attestation. A reported failure (FAILED=) is final for that head: fix it in a new commit.

Problem

The template's agent rules spread verification across AGENTS.md, docs/CI.md and a 108-line github-prs skill that mixed checks with PR mechanics, so agents rerun checks remotely or run them twice (locally and in a Davit box).

Fix

  • Add the local-ci skill (21 lines, .claude and .agents mirrors identical). It owns verification: make check-fast, make check-pr, make ci-local, failed heads, "never rerun remotely what you ran locally", and make box-ci instead of a local run, never in addition.
  • Trim github-prs to PR mechanics only: open, stack, merge (make pr-merge, make land), after the merge. It no longer overlaps local-ci.
  • Point AGENTS.md, CONTEXT.md, README, RELEASES.md, the check-pr help and check-pr.sh at the skill that now owns each topic.

The template has no Gate workflow, so there is nothing to delete.

Stacked on #151.

Local verification

Filled by make ci-local, 2026-11-17T08:30:07Z. Never edit this section by hand.

Head 82306c8e9616756436b389dc670159c883a292c9 · tree a81d58367545 · passed
Attested by JJ Eaton on Studio-01

Ran: make check-fast; make ci-pg (make ci, make check-migrations, release smoke on a throwaway Postgres 18); make secret-scan

🤖 Generated with Claude Code

@jayleaton
jayleaton force-pushed the chore/agent-config-cleanup branch from 393a704 to 715f087 Compare November 17, 2026 08:24
@jayleaton
jayleaton force-pushed the chore/local-ci-skill branch 2 times, most recently from d97de22 to 73d2f72 Compare November 17, 2026 08:27
@jayleaton
jayleaton changed the base branch from chore/agent-config-cleanup to main November 17, 2026 08:28
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayleaton
jayleaton force-pushed the chore/local-ci-skill branch from 73d2f72 to 82306c8 Compare November 17, 2026 08:29
@jayleaton
jayleaton merged commit 4476e93 into main Nov 17, 2026
4 checks passed
@jayleaton

Copy link
Copy Markdown
Owner Author

Authorized by JJ, merged by Doug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant