This repository was archived by the owner on May 28, 2018. It is now read-only.
Fix IndexOutOfBoundsException in ReflectionHelper for methods named "get"#3620
Open
pieter-van-prooijen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When annotating response objects with @RolesAllowed and enabling the SecurityEntityFilteringFeature, jersey will throw an IndexOutOfBoundsException when scanning the properties for (nested) objects which contain a method just named "get" (without an actual property name after the get).
In my case, this is a Mongo ObjectId instance (for which a custom mapper has been registered).
The cause is in the ReflectionHelper method getMethodName, which does not take this edge case into account. I've created a fix and a test for this issue.
Let me know if you need more information.
Kind Regards,
Pieter van Prooijen