Repository navigation
fix(win32): correct SetCursorPos argument types (#1745) - #1750
OKAN-SOFTWARE wants to merge 1 commit into
Conversation
|
Please squash into one commit. There is no additional value in splitting this.
Why not? How did you determine, that they actually work? The tests can be run in isolation, even from CLI. This call for example: executed from the base of the source tree, will run only tests that are located in a file called
This is wrong. The problem is not the java side of the equation. That will compile (one platform is enough to verify that), the interesting question is: Will the interaction with the native library work. That need exection on a 32bit platform. |
11d9663 to
6f7b6ca
Compare
|
Follow-up on the 32-bit native runtime verification: I completed the Windows x86 verification using Azul Zulu JDK 17 (32-bit).
The tests executed against the PR's locally built JNA artifacts using the 32-bit JVM, including the native The earlier 64-bit Windows test run also passed (41 tests, 0 failures, 2 skipped). The requested changes remain squashed into a single commit. This completes the 32-bit runtime verification requested in your earlier feedback. Thank you for the guidance! |
Fixes #1745.
Summary
Correct the Windows
User32.SetCursorPosmapping to use the native API's 32-bitintcoordinates, while preserving the existinglongoverload for binary compatibility.Changes
SetCursorPos(int x, int y)with the correct Windows API parameter types.SetCursorPos(long x, long y)and mark it@Deprecatedfor binary compatibility.CHANGES.md.6f7b6ca3), as requested.Testing
Windows 11 — 64-bit JVM
ant "-Dtests.include=**/User32Test.java" test-platformWindows 11 — 32-bit JVM (native runtime verification)
os.arch=x86andsun.arch.data.model=32.org.junit.runner.JUnitCore com.sun.jna.platform.win32.User32Testwith the PR's locally built JNA and JNA Platform artifacts on the classpath.OK (39 tests), with 2 tests ignored; JUnit exit code 0.User32Testsuite includes a nativeSetCursorPosinvocation using the correctedintoverload. No native invocation failures were observed.git diff --checkalso passed.Notes
The 32-bit Windows runtime verification requested during review has now been completed successfully. No further code changes were needed for this validation.