Skip to content

Fix jamulus/pollServerList reporting success on invalid directory address #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcfnord wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −7
Open

Fix jamulus/pollServerList reporting success on invalid directory address #3820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4a6ad
Fix jamulus/pollServerList reporting success on invalid address
Jul 21, 2026
d90fbb6
Align with existing code style
dingodoppelt Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/clientrpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,18 +190,15 @@ CClientRpc::CClientRpc ( CClient* pClient, CClientSettings* pSettings, CRpcServe
CHostAddress haDirectoryAddress;

// Allow IPv4 only for communicating with Directories
if ( NetworkUtil::ParseNetworkAddress ( jsonDirectoryIp.toString(), haDirectoryAddress, false ) )
{
// send the request for the server list
pClient->CreateCLReqServerListMes ( haDirectoryAddress );
response["result"] = "ok";
}
else
if ( !NetworkUtil::ParseNetworkAddress ( jsonDirectoryIp.toString(), haDirectoryAddress, false ) )
{
response["error"] =
CRpcServer::CreateJsonRpcError ( CRpcServer::iErrInvalidParams, "Invalid params: directory is not a valid socket address" );
return;
}

// send the request for the server list
pClient->CreateCLReqServerListMes ( haDirectoryAddress );
response["result"] = "ok";
Comment thread
mcfnord marked this conversation as resolved.
} );

Expand Down
Loading