Repository navigation
fix: scope native order reminders to the current futures symbol - #308
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binance currently delivers account-wide fill and cancellation reminders in every futures tab, so one symbol can produce unrelated toasts and overlapping sounds across multiple pages. Orderbook v2.7.220 scopes ordinary order reminders to each tab's current symbol and rechecks delayed notifications after symbol changes, while preserving native switches and risk or unknown events.
The change pins the native toast and sound consumers and shares the existing early module observer. It leaves the account data stream and trading state intact; both sound modules must match before changing their shared queue contract. Source drift remains native and is reported in the diagnostic snapshot.
Validation:
Tampermonkey synchronization and exact installed-source verification follow the merge. Live trade-generated notification behavior has not yet been exercised.