Skip to content

fix: scope native order reminders to the current futures symbol - #308

Merged
jackhai9 merged 1 commit into
mainfrom
fix/order-notifications-current-symbol
Oct 7, 2026
Merged

jackhai9 merged 1 commit into
mainfrom
fix/order-notifications-current-symbol

Conversation

@jackhai9

@jackhai9 jackhai9 commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Binance currently delivers account-wide fill and cancellation reminders in every futures tab, so one symbol can produce unrelated toasts and overlapping sounds across multiple pages. Orderbook v2.7.220 scopes ordinary order reminders to each tab's current symbol and rechecks delayed notifications after symbol changes, while preserving native switches and risk or unknown events.

The change pins the native toast and sound consumers and shares the existing early module observer. It leaves the account data stream and trading state intact; both sound modules must match before changing their shared queue contract. Source drift remains native and is reported in the diagnostic snapshot.

Validation:

  • 2,225 Node tests passed, including 51 native React/notification regressions.
  • 143 chart-storage browser regressions and 2 new multi-page/SPA notification browser scenarios passed using the generated artifact.
  • Build, syntax, test lint, source-pin/inverse checks and independent implementation review passed.
  • The unmodified native factories reproduced foreign-symbol toast and audio delivery before the fix. No live order was placed or cancelled to test this change.

Tampermonkey synchronization and exact installed-source verification follow the merge. Live trade-generated notification behavior has not yet been exercised.

@jackhai9
jackhai9 merged commit 88df8ff into main Oct 7, 2026
3 checks passed
@jackhai9
jackhai9 deleted the fix/order-notifications-current-symbol branch October 7, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant