Repository navigation
fix: stop other-symbol tabs from restoring deleted drawings - #307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting all MUBARAKUSDT drawings could appear successful and still restore the same 20 drawings after reload. A different-symbol tab retained those drawings as hidden sources; Binance's native save wrote every retained symbol group back. This reproduces without the mirror optimizer.
Orderbook v2.7.219 restricts native save extraction to each chart's current MainSeries symbols before drawing-ID deduplication. Indicator panes inherit their chart's symbols, current-symbol deletion still writes an explicit empty array, and unrelated symbols' current database records remain untouched. The complete pinned 76535 factory changes only that extraction input. One bootstrap observer captures it and the existing 70940 mirror independently; stopping the optional mirror optimizer retains drawing protection.
Validation:
All old trading tabs must load the new version because an old tab can still write hidden copies. This change does not arbitrate simultaneous editors of the same symbol, repair prior records, or solve source-only cross-database interruption. No trading action is required for acceptance. Detailed evidence and boundaries are in docs/binance-futures-blank-page-diagnosis.md and docs/binance-chart-storage-development.md.