Repository navigation
fix: isolate signal overlays from chart persistence - #305
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary signal drawings trigger Binance chart-save callbacks even when excluded from saved chart JSON. Move Strategy27 event/compound markers and Strategy29/31 markers to a shared, pane-clipped SVG renderer so their updates no longer enter the native drawing/save pipeline. Keep signal thresholds, candle placement, retention, and trading behavior unchanged.
Preserve orderbook serialization batching while delivering every accepted default save callback with an independent snapshot. Explicit save signatures retain native behavior; cleanup preserves callback ownership and reports both action and serialization failures. Regression tests cover callback reentry, external wrappers, interval changes before the first marker, and stale rendering after failures.
Validation:
Versions: orderbook 2.7.217, Strategy27 0.6.8, Strategy29 0.5.8, Strategy31 0.1.2.
This removes verified marker-generated save traffic and callback loss; it does not establish that every Chrome IndexedDB stall is fixed. Live installation/readback follows publication. The active US trading task will not be interrupted for validation. No live financial actions are included.