Skip to content

Read GITHUB_REF and GITHUB_REPOSITORY lazily in github.rkt #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackfirth merged 1 commit into from
Jul 15, 2026
Merged

Read GITHUB_REF and GITHUB_REPOSITORY lazily in github.rkt #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions private/github.rkt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ EOS
#:end-side "RIGHT"))


(define branch-ref (getenv "GITHUB_REF"))
(define github-repository (getenv "GITHUB_REPOSITORY"))
(define (branch-ref) (getenv "GITHUB_REF"))
(define (github-repository) (getenv "GITHUB_REPOSITORY"))


(define (github-review-body comments? file-count)
Expand All @@ -153,8 +153,8 @@ EOS
(define comments
(transduce results (mapping refactoring-result->github-review-comment) #:into into-list))
(github-review-request
#:owner-repo github-repository
#:pull-number (git-ref->pr-number branch-ref)
#:owner-repo (github-repository)
#:pull-number (git-ref->pr-number (branch-ref))
#:body (github-review-body (not (null? comments)) file-count)
#:event (if (empty? comments) "APPROVE" "COMMENT")
#:comments comments))
Expand Down Expand Up @@ -236,6 +236,19 @@ EOS
(check-exn exn:fail? (lambda () (git-ref->pr-number "refs/heads/main")))
(check-exn exn:fail? (lambda () (git-ref->pr-number "refs/pull/42/head")))
(check-exn exn:fail? (lambda () (git-ref->pr-number "invalid")))))
(test-case "refactoring-results->github-review reads GITHUB_REF and GITHUB_REPOSITORY lazily"
(parameterize ([current-environment-variables
(make-environment-variables
#"GITHUB_REF" #"refs/pull/42/merge"
#"GITHUB_REPOSITORY" #"owner/repo")])
(define review (refactoring-results->github-review '() #:file-count 3))
(define jsexpr (github-review-request-jsexpr review))
(check-equal? (hash-ref jsexpr 'owner) "owner")
(check-equal? (hash-ref jsexpr 'repo) "repo")
(check-equal? (hash-ref jsexpr 'pull_number) 42)
(check-equal? (hash-ref jsexpr 'event) "APPROVE")
(check-equal? (hash-ref jsexpr 'comments) '())
(check-equal? (hash-ref jsexpr 'body) (github-review-body #false 3))))
(test-case "github-review-body"
(test-case "with comments"
(check-equal? (github-review-body #t 1)
Expand Down
Loading