Prevent virtual keyboard events from hiding the virtual joystick - #2949
Open
terranprog wants to merge 2 commits into
Open
Prevent virtual keyboard events from hiding the virtual joystick#2949terranprog wants to merge 2 commits into
terranprog wants to merge 2 commits into
Conversation
Member
|
I added a commit to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2948
This PR adds extra checks to make sure only a real physical keyboard can cause the virtual joystick to disappear when in VIRTUAL_JOYSTICK_AUTO mode.
Disclaimer: I asked A.I. to diagnose this observed issue and it suggested the following code fix. I have run my app with this code change and have not seen the issue reoccur. I did not write the fix myself but it makes sense as far as I can tell.