Skip to content

Reorganize project structure - #26

Merged
j0code merged 5 commits into
mainfrom
reorganize-project-structure
May 25, 2026
Merged

Reorganize project structure#26
j0code merged 5 commits into
mainfrom
reorganize-project-structure

Conversation

@j0code

@j0code j0code commented May 24, 2026

Copy link
Copy Markdown
Owner

This pr reorganizes the project structure:

  • components are logically grouped (views, forms, form-comps)
  • 2pills.png is moved from public to public/assets
  • css files are moved to the public dir and imported using html rather than vite css imports
  • obsolete parts of vite.config.js are removed

Review / suggestions requested.

@j0code
j0code requested a review from cfpwastaken May 24, 2026 15:01
@j0code j0code added the help wanted Extra attention is needed label May 24, 2026
@cfpwastaken

Copy link
Copy Markdown
Collaborator

css files are moved to the public dir and imported using html rather than vite css imports

why?

@j0code

j0code commented May 24, 2026

Copy link
Copy Markdown
Owner Author

css files are moved to the public dir and imported using html rather than vite css imports

why?

Makes sense to me to group them with the other public files and put them in their own folder.
This way we can also add more css files without cluttering the root dir of the package.

@cfpwastaken cfpwastaken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that it looks good so far

Comment thread client/src/comps/TagList.ts Outdated
@cfpwastaken

Copy link
Copy Markdown
Collaborator

css files are moved to the public dir and imported using html rather than vite css imports

why?

Makes sense to me to group them with the other public files and put them in their own folder. This way we can also add more css files without cluttering the root dir of the package.

valid

@cfpwastaken
cfpwastaken force-pushed the reorganize-project-structure branch from 87b8834 to 3f79a24 Compare May 25, 2026 14:53
@j0code
j0code marked this pull request as ready for review May 25, 2026 14:59
@j0code
j0code enabled auto-merge (squash) May 25, 2026 15:00
@j0code
j0code requested a review from cfpwastaken May 25, 2026 15:05
cfpwastaken
cfpwastaken previously approved these changes May 25, 2026
@cfpwastaken
cfpwastaken force-pushed the reorganize-project-structure branch from b4c14d8 to 899190f Compare May 25, 2026 15:30
@j0code
j0code disabled auto-merge May 25, 2026 17:02
@j0code
j0code merged commit 413593b into main May 25, 2026
5 checks passed
@j0code
j0code deleted the reorganize-project-structure branch May 25, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants