Skip to content

Release v1.2.4: fix video selection with embedded covers - #22

Merged
ixiehao merged 1 commit into
mainfrom
fix/video-stream-selection
Oct 20, 2026
Merged

ixiehao merged 1 commit into
mainfrom
fix/video-stream-selection

Conversation

@ixiehao

@ixiehao ixiehao commented Oct 20, 2026

Copy link
Copy Markdown
Owner

An embedded cover can be exposed as a video stream, causing first-video selection to choose the image instead of the movie and producing misleading multi-video warnings. Exclude flagged cover art and timed thumbnails, carry the inspected stream index through FFmpeg conversion and merging, and match the native enhancement track by its MOV/MP4 track ID. Reject cover-only input/output and ambiguous native selection; require matching stream layouts for lossless concat.

Release v1.2.4 (build 10) includes synchronized English, Chinese and Japanese policy/README text and concise release notes.

Validation completed locally:

  • 60 Swift tests: 59 passed, 1 opt-in customer-media benchmark skipped. Native Smart Enhance ran successfully with an embedded cover.
  • 28 synthetic-media contract checks passed; localization validation passed.
  • Cover-first probe responses and actual embedded-cover files exercise selection, editor dimensions, stream copying, software/hardware rotation and both merge routes; frame counts, changing decoded frames, duration and copied movie hashes are checked.
  • Isolated universal app GUI: movie + cover succeeds without a false two-video warning; two actual movie tracks keep the real warning; audio + cover fails clearly. Retained results verified in English, Chinese and Japanese.

Packaging uses the existing ad-hoc, unnotarized workflow. Final DMG and public download verification are part of the release procedure.

@ixiehao
ixiehao merged commit f11a464 into main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant