fix(webwalker): reject unconfirmed route action frontiers - #36
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe walker now treats only catalog-backed transport boundaries as route actions. Unresolved collision frontiers remain ground-movement responsibilities. A regression test verifies that no action edge is selected. ChangesRoute frontier filtering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Unconfirmed collision frontiers now remain ground-movement responsibilities instead of triggering route actions, while catalog-backed transports continue to work. The focused regression coverage indicates no current merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
What\nPrevent unconfirmed collision frontiers from being treated as executable WebWalker route actions.\n\n## Why\nThe live client repeatedly retried the same route edge at WorldPoint(3005, 3336) toward (3012, 3355), producing repeated route-action-failed replans and suppressing normal forward movement.\n\n## Change\n- Keep catalog-backed doors/transports as action edges.\n- Return no action for generic reachable-from/unreachable-to frontiers.\n- Preserve the guard that prevents leapfrogging an unresolved frontier to a later catalog transport.\n- Add a regression test.\n\n## Testing\n- :client:runUnitTests --tests net.runelite.client.plugins.microbot.util.walker.RuneLiteWebWalkRuntimeTest\n- 35 tests passed\n- git diff --check passed
Summary by CodeRabbit
Bug Fixes
Tests