Skip to content

fix(webwalker): reject unconfirmed route action frontiers - #36

Merged
itsBOTzilla merged 1 commit into
mainfrom
fix/webwalker-route-action-frontier
Sep 5, 2026
Merged

fix(webwalker): reject unconfirmed route action frontiers#36
itsBOTzilla merged 1 commit into
mainfrom
fix/webwalker-route-action-frontier

Conversation

@itsBOTzilla

@itsBOTzilla itsBOTzilla commented Sep 5, 2026

Copy link
Copy Markdown
Owner

What\nPrevent unconfirmed collision frontiers from being treated as executable WebWalker route actions.\n\n## Why\nThe live client repeatedly retried the same route edge at WorldPoint(3005, 3336) toward (3012, 3355), producing repeated route-action-failed replans and suppressing normal forward movement.\n\n## Change\n- Keep catalog-backed doors/transports as action edges.\n- Return no action for generic reachable-from/unreachable-to frontiers.\n- Preserve the guard that prevents leapfrogging an unresolved frontier to a later catalog transport.\n- Add a regression test.\n\n## Testing\n- :client:runUnitTests --tests net.runelite.client.plugins.microbot.util.walker.RuneLiteWebWalkRuntimeTest\n- 35 tests passed\n- git diff --check passed

Summary by CodeRabbit

  • Bug Fixes

    • Improved route handling so unresolved path boundaries remain standard movement rather than being treated as executable interactions.
    • Restricted route actions to confirmed transport boundaries, preventing unintended interactions during navigation.
  • Tests

    • Added coverage to verify that nearby unresolved collision boundaries do not trigger route actions.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: a8dd9e9b-1a5c-408a-9420-e32369ae81dc

📥 Commits

Reviewing files that changed from the base of the PR and between f936ad8 and 9087a28.

📒 Files selected for processing (2)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/RuneLiteWebWalkRuntime.java
  • runelite-client/src/test/java/net/runelite/client/plugins/microbot/util/walker/RuneLiteWebWalkRuntimeTest.java

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The walker now treats only catalog-backed transport boundaries as route actions. Unresolved collision frontiers remain ground-movement responsibilities. A regression test verifies that no action edge is selected.

Changes

Route frontier filtering

Layer / File(s) Summary
Filter unresolved frontiers and validate movement
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/RuneLiteWebWalkRuntime.java, runelite-client/src/test/java/net/runelite/client/plugins/microbot/util/walker/RuneLiteWebWalkRuntimeTest.java
routeActionIndex no longer selects unresolved generic frontiers. The regression test verifies that an unconfirmed nearby frontier returns -1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 9087a

Unconfirmed collision frontiers now remain ground-movement responsibilities instead of triggering route actions, while catalog-backed transports continue to work. The focused regression coverage indicates no current merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: rejecting unconfirmed route-action frontiers in WebWalker.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/webwalker-route-action-frontier

Comment @coderabbitai help to get the list of available commands.

@itsBOTzilla
itsBOTzilla merged commit 72c42e1 into main Sep 5, 2026
3 checks passed
@itsBOTzilla
itsBOTzilla deleted the fix/webwalker-route-action-frontier branch September 5, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant