Repository navigation
Expose the peer close code in the WebSocketClient onclose callback - #932
Open
lizezhong233 wants to merge 1 commit into
Open
lizezhong233 wants to merge 1 commit into
lizezhong233 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #553.
The C++ client already echoes a peer's WebSocket CLOSE payload and invokes
onclose()when the transport disconnects. With this change, applications can callgetCloseCode()inside that same callback. A nonnegative result is the peer's 16-bit status code in host byte order.WebSocketClient::CloseCodeonclose()NoCloseStatusLocalCloseNoCloseFrameThe client records the code on the connection before echoing the original payload. It clears the result after the disconnect callback, including when the next attempt fails before the WebSocket handshake. The callback signature and timing stay the same. Frame validation continues to use the existing parser.
Compatibility
Existing zero-argument callbacks compile as written. The additional member changes the layout of the exported C++
WebSocketChannelclass. Consumers of the shared C++ library should rebuild against the matching headers.Tests
examples/websocket_client_test.cppagainst both the baseline and the updated library. Both runs produced the same callbacks and echoed1000 / done.