Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
On Linux shared-library builds with bundled curl and BoringSSL, the current manual linker markers surround the CMake interface target names. CMake expands those targets after the markers, so the generated link command contains an empty group and leaves
libcurl.a,libssl.a, andlibcrypto.aungrouped. GNU ld then leaves strong TLS symbols unresolved inlibOpen3D.so, and importing the Python package fails.Checklist:
python util/check_style.py --applyto apply Open3D code style to my code.Description
This applies CMake's
LINK_GROUP:RESCANfeature to the concrete build-tree archives used by the bundled curl target. It preserves the target's install-interface entries and leaves system curl/OpenSSL and Apple builds unchanged.The generated Open3D shared-library link command now contains:
The separate MKL archive group remains intact.
Validation on Ubuntu x86-64, Open3D
b6c5e1963:BUILD_SHARED_LIBS=ON, bundled curl, and bundled BoringSSL.pip-packagetarget successfully.open3dpackage successfully (0.20.0+b6c5e1963).open3d.core.Device("CPU:0")successfully.nm -D --undefined-only libOpen3D.so.0.20.0contains no strong OpenSSL/TLS undefined symbols; only BoringSSL's three expected weak memory hooks remain.python util/check_style.py --applypasses.