Skip to content

Fix the preview reaper: it never actually read a PR state #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaaclins merged 1 commit into from
Aug 5, 2026
Merged

Fix the preview reaper: it never actually read a PR state #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/pr-preview-reaper.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ jobs:

response_file="$(mktemp)"
api_exit=0
gh api --include --silent "repos/$REPOSITORY/pulls/$pr_number" >"$response_file" || api_exit=$?
# No --silent here. It suppresses the response body, which leaves the
# file holding headers only, so the state parse below finds nothing
# and every run dies on the first preview it inspects.
gh api --include "repos/$REPOSITORY/pulls/$pr_number" >"$response_file" || api_exit=$?
status_code="$(awk '/^HTTP\/[^ ]+ / { code=$2 } END { print code }' "$response_file")"

if (( api_exit == 0 )); then
Expand Down
Loading