Skip to content

Add PIM logNeighborChanges field #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgildein wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add PIM logNeighborChanges field #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/core/v1alpha1/pim_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ type PIMSpec struct {
// +kubebuilder:default=Up
AdminState AdminState `json:"adminState,omitempty"`

// LogNeighborChanges enables logging when a PIM neighbor is added or removed.
// +optional
LogNeighborChanges *bool `json:"logNeighborChanges,omitempty"`

// RendezvousPoints defines the list of rendezvous points for sparse mode multicast.
// +optional
// +listType=map
Expand Down
5 changes: 5 additions & 0 deletions api/core/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions charts/network-operator/templates/crd/pim.networking.metal.ironcore.dev.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions config/crd/bases/networking.metal.ironcore.dev_pim.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions docs/api-reference/index.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions internal/provider/cisco/nxos/pim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ func (*PIM) XPath() string {
}

type PIMDom struct {
Name string `json:"name"`
AdminSt AdminSt `json:"adminSt"`
Name string `json:"name"`
AdminSt AdminSt `json:"adminSt"`
LogNbhChng *bool `json:"logNbhChng,omitempty"`
}

func (*PIMDom) IsListItem() {}
Expand Down
7 changes: 7 additions & 0 deletions internal/provider/cisco/nxos/pim_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,11 @@ func init() {
rp := &StaticRP{Addr: "10.0.0.100/32"}
rp.RpgrplistItems.RPGrpListList.Set(&StaticRPGrp{GrpListName: "224.0.0.0/4"})
Register("pim_rp", rp)

logEnabled := true
Register("pim_dom_log", &PIMDom{
Name: "default",
AdminSt: AdminStEnabled,
LogNbhChng: &logEnabled,
})
}
1 change: 1 addition & 0 deletions internal/provider/cisco/nxos/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2389,6 +2389,7 @@ func (p *Provider) EnsurePIM(ctx context.Context, req *provider.EnsurePIMRequest
if req.PIM.Spec.AdminState == v1alpha1.AdminStateDown {
dom.AdminSt = AdminStDisabled
}
dom.LogNbhChng = req.PIM.Spec.LogNeighborChanges
sb.Patch(dom)

rpItems := new(StaticRPItems)
Expand Down
15 changes: 15 additions & 0 deletions internal/provider/cisco/nxos/testdata/pim_dom_log.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"pim-items": {
"inst-items": {
"dom-items": {
"Dom-list": [
{
"name": "default",
"adminSt": "enabled",
"logNbhChng": true
}
]
}
}
}
}
1 change: 1 addition & 0 deletions internal/provider/cisco/nxos/testdata/pim_dom_log.json.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ip pim log-neighbor-changes
2 changes: 2 additions & 0 deletions test/gnmi/testdata/cisco-nxos-gnmi/pim.txtar
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ spec:
deviceRef:
name: device
adminState: Up
logNeighborChanges: true
interfaceRefs:
- name: lo-pim
mode: Sparse
Expand Down Expand Up @@ -119,6 +120,7 @@ spec:
{
"name": "default",
"adminSt": "enabled",
"logNbhChng": true,
"if-items": {
"If-list": [
{
Expand Down
Loading