Use artifacts to store compiled tester image - #802
Merged
byteocean merged 1 commit intoJul 17, 2026
Merged
Conversation
byteocean
force-pushed
the
ci/upload-artifact-during-test
branch
2 times, most recently
from
July 16, 2026 14:47
3bce97a to
3934ba3
Compare
mkalcok
requested changes
Jul 16, 2026
mkalcok
left a comment
mkalcok
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, thank you. I think there's one left-over secret reference that's no longer needed (see below).
Signed-off-by: Tao Li <tao.li06@sap.com>
byteocean
force-pushed
the
ci/upload-artifact-during-test
branch
from
July 16, 2026 15:03
3934ba3 to
ff772a5
Compare
mkalcok
approved these changes
Jul 17, 2026
mkalcok
left a comment
mkalcok
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the updates.
maxmoehl
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the suggestion from @mkalcok, use artifacts to store resulted tester image.