fix(files): blank screen when navigating mid-load - #2501
Merged
Conversation
doFilesFetch does nothing while another listing is in flight, so navigating during a slow load dropped the new path's fetch, and nothing retried it. The view then held content for the path we had left, which the stale-path guard renders as an empty screen: no listing, and no error page for a path that does not exist. Re-check the route once the in-flight fetch settles and fetch again if it moved. Also runs when the fetch fails, since that leaves the new path just as unfetched.
lidel
changed the title
lidel
marked this pull request as ready for review
July 29, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Open a folder that is slow to list, click through to another path before it finishes, and you land on a blank screen: no listing, and for a path that does not exist, not even the error page. It stays blank until you navigate somewhere else.
doFilesFetchskips its work while another listing is in flight, and the navigation's own call is exactly that. Nothing retries it, so the view still holds content for the path you left, and the stale-path guard inMainViewrightly refuses to render it.Fix
The guard from #2437 stays as it is: it was doing the right thing, and the fetch it was waiting on never came. Still one listing at a time, so no extra concurrent requests.