Skip to content

The Travis CI build should be organized.Β #65

Description

@peter279k

πŸ‘¨β€πŸŽ¨
According to the Travis CI build log from my forked repository. I found some existed problems.

  • It's not really necessary to do the static analysis with phpstan in Travis CI build at this time.
    It should be removed. We have the unit tests and this is the optional enhancement work.
  • I think it's okay to use the php-cs-fixer to check the coding style.
  • I think the unit test looks like it's too slow. Perhaps it has some HTTP requests tests to cause this issue.
    IMHO, it should set the optional argument timeout for HTTP requests in php-http client so that it can let the execution time of unit test faster πŸ‘.

BTW, we can integrate the Travis CI service so that we can check where the problem is via unit test work πŸ˜„.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions