Repository navigation
test: cover taking, saving, loading, and deleting photos - #76
Open
brandyscarney wants to merge 1 commit into
Open
brandyscarney wants to merge 1 commit into
brandyscarney wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
force-pushed
the
chore/add-test-coverage
branch
from
October 23, 2026 17:45
d4e7b72 to
2330e2c
Compare
brandyscarney
force-pushed
the
chore/add-test-coverage
branch
from
October 23, 2026 19:16
2330e2c to
81444a1
Compare
This was referenced Oct 23, 2026
brandyscarney
force-pushed
the
chore/add-test-coverage
branch
from
October 23, 2026 21:57
81444a1 to
10e098a
Compare
brandyscarney
force-pushed
the
chore/add-test-coverage
branch
from
October 23, 2026 21:57
10e098a to
ae71086
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Adds tests for the app's functionality: switching tabs, the Explore UI Components link on Tab 1 and Tab 3, and taking, saving, loading, and deleting photos.
New Behavior
Changes
usePhotoGallery.test.ts: the hook takes photos on the web and on native (including native file data returned as a Blob), loads saved photos, and deletes photos, with the Capacitor plugins andisPlatformmocked.Tab2.test.tsx: the page shows a thumbnail per photo, takes a photo from the camera button, and opens the action sheet when a photo is tapped. Delete deletes that photo and closes the sheet.e2e/app.spec.ts: the app opens on Tab 1; the tab bar switches between Tab 1, Photos, and Tab 3, with the right URL, title, and selected tab each time; Tab 1 and Tab 3 show their page name and an "Explore UI Components" link to https://ionicframework.com/docs/components that opens in a new tab.e2e/gallery.spec.ts: taking a photo adds it to the gallery; photos are still there after a reload, loaded from storage; Delete in the action sheet removes a photo, and after a reload the other photo loads and the deleted one stays gone; Cancel keeps the photo; a photo taken after a delete shows up as the only photo, including after a reload.ExploreContainerusesid="container"and#containerstyles, matching the Angular and Vue apps (it used a.containerclass).Notes
--repeat-each=5).