Skip to content

chore(lint): add eslint and prettier with ionic configs and CI workflow - #72

Open
brandyscarney wants to merge 2 commits into
mainfrom
chore/add-lint-workflow
Open

brandyscarney wants to merge 2 commits into
mainfrom
chore/add-lint-workflow

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

What This Does

Adds linting and formatting to the React tutorial app using Ionic's shared ESLint and Prettier configs, and adds a CI workflow that checks every pull request.

New Behavior

  • npm run lint checks the code with ESLint, then Prettier. npm run lint:fix fixes what it can automatically.
  • Every pull request runs a Lint job on Linux, plus a Test job on Windows and macOS that builds the app and runs the unit tests (Vitest).
  • VS Code suggests the ESLint, Prettier, and Webnative extensions.

Changes

  • ESLint 10 with @ionic/eslint-config (recommended) plus eslint-plugin-react-hooks and eslint-plugin-react-refresh
  • Prettier 3 with @ionic/prettier-config. The source is reformatted, and the remaining lint errors are fixed.
  • Scripts: lint, lint:fix, eslint, and prettier
  • .github/workflows/CI.yml
  • renovate.json: @ionic/eslint-config and @ionic/prettier-config move out of the ionic group and into the lint/dev-tools group
  • .vscode/extensions.json, and .editorconfig (from the Ionic Angular starter)
  • .prettierignore for android/ and ios/: Prettier only reads the root .gitignore, so it would otherwise check Capacitor's copied web build and Gradle's build output
  • A Linting section in the README
  • Adds the ESLint config this repo was missing (ESLint was installed but had no config).
  • Removes eslint-plugin-react, which doesn't support ESLint 10, and the Renovate rule that held ESLint below 10 because of it.

Notes

  • @typescript-eslint/explicit-module-boundary-types is set to warn here (the level in Ionic's base config). The next PR fixes those warnings and makes the rule an error again.
  • Lint runs on Linux only: Windows runners check out with CRLF line endings, which Prettier would report as formatting changes.
  • The Prettier reformat touches code the "Your First App" docs teach. Once this stack merges, a follow-up ionic-docs PR will update the snippets to match.

@brandyscarney
brandyscarney requested a review from a team as a code owner October 23, 2026 16:00
@brandyscarney
brandyscarney requested review from thetaPC and removed request for a team October 23, 2026 16:00
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tutorial-photo-gallery-react Ready Ready Preview Oct 23, 2026 7:09pm UTC

Request Review

@brandyscarney
brandyscarney added this pull request to stack #74 October 23, 2026 16:11

This branch was successfully deployed

1 active deployment
Preview — 0c979d68 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant