Repository navigation
chore(lint): add eslint and prettier with ionic configs and CI workflow - #72
Open
brandyscarney wants to merge 2 commits into
Open
brandyscarney wants to merge 2 commits into
brandyscarney wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
added this pull request to stack #74
October 23, 2026 16:11
This was referenced Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This Does
Adds linting and formatting to the React tutorial app using Ionic's shared ESLint and Prettier configs, and adds a CI workflow that checks every pull request.
New Behavior
npm run lintchecks the code with ESLint, then Prettier.npm run lint:fixfixes what it can automatically.Changes
@ionic/eslint-config(recommended) pluseslint-plugin-react-hooksandeslint-plugin-react-refresh@ionic/prettier-config. The source is reformatted, and the remaining lint errors are fixed.lint,lint:fix,eslint, andprettier.github/workflows/CI.ymlrenovate.json:@ionic/eslint-configand@ionic/prettier-configmove out of theionicgroup and into the lint/dev-tools group.vscode/extensions.json, and.editorconfig(from the Ionic Angular starter).prettierignoreforandroid/andios/: Prettier only reads the root.gitignore, so it would otherwise check Capacitor's copied web build and Gradle's build outputeslint-plugin-react, which doesn't support ESLint 10, and the Renovate rule that held ESLint below 10 because of it.Notes
@typescript-eslint/explicit-module-boundary-typesis set towarnhere (the level in Ionic's base config). The next PR fixes those warnings and makes the rule an error again.