Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # core/src/components/toolbar/test/colors/toolbar.e2e.ts-snapshots/toolbar-colors-ionic-md-ltr-light-Mobile-Safari-linux.png
# Conflicts: # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-ltr-light-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-ltr-light-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-ltr-light-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-rtl-light-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-rtl-light-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-ios-rtl-light-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-ltr-light-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-ltr-light-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-ltr-light-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-rtl-light-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-rtl-light-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ionic-md-rtl-light-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-ltr-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-md-rtl-Mobile-Safari-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-ltr-light-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-ltr-light-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-ltr-light-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-rtl-light-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-rtl-light-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-ios-rtl-light-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-ltr-light-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-ltr-light-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-ltr-light-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-rtl-light-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-rtl-light-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ionic-md-rtl-light-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png
# Conflicts: # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-md-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-md-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-md-ltr-Mobile-Safari-linux.png
There was a problem hiding this comment.
The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made these buttons dark. Expect md solid buttons in an ion-buttons without a toolbar to match the standalone buttons above. Buttons inside a toolbar render the same as before.
There was a problem hiding this comment.
The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made these buttons dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.
There was a problem hiding this comment.
The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made this icon dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.
There was a problem hiding this comment.
The migration moved md's toolbar button styling from ion-buttons to IonToolbar.IonButton tokens, since those colors come from the toolbar. Before, an ion-buttons outside a toolbar picked them up anyway, which made this button dark. Expect md buttons in an ion-buttons without a toolbar to look like standalone buttons. Buttons inside a toolbar render the same as before.
There was a problem hiding this comment.
Icon-only buttons in a select's start and end slots now follow the button's shape instead of being forced into circles, so ios shows its default soft shape. Input and textarea slots behave the same. Set shape="round" to keep them circular, as listed in #31628's breaking changes.
There was a problem hiding this comment.
Icon-only buttons in a textarea's start and end slots now follow the button's shape instead of being forced into circles, so ios shows its default soft shape. Input and select slots behave the same. Set shape="round" to keep them circular, as listed in #31628's breaking changes.
There was a problem hiding this comment.
The track's gray changed in #31457, but the difference is too small to fail the screenshot comparison, so its snapshots were never regenerated. This page fails here because the 40px ionic toolbar buttons make the header shorter, and regenerating it also picks up the new gray. Other toggle snapshots still show the old gray and will update the next time something else changes them.
There was a problem hiding this comment.
Known gap: pressed outline buttons in ios toolbars lose their fill, so the black star and label sit on the dark toolbar. The migration ported --background-activated: transparent, a next rule that never took effect, as a token that does. #31645 removes it, and the button fills again there.
There was a problem hiding this comment.
Known gap: pressed outline buttons in ios toolbars lose their fill, so the white star and label sit on the light toolbar. The migration ported --background-activated: transparent, a next rule that never took effect, as a token that does. #31645 removes it, and the button fills again there.
Issue number: resolves internal
What is the current behavior?
The button migration (#31628) changes how buttons render, but its reference snapshots haven't been updated.
What is the new behavior?
Only reference snapshots, regenerated on top of #31628 and kept here so the migration diff stays readable. The intended changes:
Any other difference is a regression. The descriptions of #31628 and its breaking changes are in that PR.
Does this introduce a breaking change?
Other information
ionic's dark snapshots show a white background on outline buttons because the test pages pin
--ion-background-colorto white. In an app, it follows the page.Toggle's ionic snapshots also catch up on #31457, which changed the track's gray without regenerating them.