chore(deps): upgrade prettier to v3 - #4674
Open
thetaPC wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
I left some comments on some of the trailing commas. I think some of the trailing commas are overkill, like inside of console.log or after <IonApp> in React apps. It might make more sense if we use this setting:
{
"trailingComma": "es5"
}
Let me know your thoughts.
| ready() { | ||
| console.log( | ||
| 'App is being served from cache by a service worker.\n' + 'For more details, visit https://goo.gl/AFskqB' | ||
| 'App is being served from cache by a service worker.\n' + 'For more details, visit https://goo.gl/AFskqB', |
Member
There was a problem hiding this comment.
Why does this add a comma to the end?
| @@ -71,7 +71,7 @@ export class ExampleComponent implements OnInit { | |||
| // Listen for changes to the media queries | |||
| prefersDark.addEventListener('change', (mediaQuery) => this.initializeDarkPalette(mediaQuery.matches)); | |||
| prefersHighContrast.addEventListener('change', (mediaQuery) => | |||
| this.initializeHighContrastPalette(mediaQuery.matches) | |||
| this.initializeHighContrastPalette(mediaQuery.matches), | |||
Member
There was a problem hiding this comment.
Why does this add a comma to the end?
| @@ -31,7 +31,7 @@ | |||
| const selectedValue = event.detail.value; | |||
|
|
|||
| console.log( | |||
| `Expanded: ${selectedValue === undefined ? 'None' : event.detail.value} | Collapsed: ${collapsedItems.join(', ')}` | |||
| `Expanded: ${selectedValue === undefined ? 'None' : event.detail.value} | Collapsed: ${collapsedItems.join(', ')}`, | |||
Member
There was a problem hiding this comment.
Why does this add a comma to the end?
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| const validateEmail = (email) => { | |||
| return email.match( | |||
| /^(?=.{1,254}$)(?=.{1,64}@)[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+)*@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/ | |||
| /^(?=.{1,254}$)(?=.{1,64}@)[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+)*@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/, | |||
Member
There was a problem hiding this comment.
Why does this add a comma to the end?
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| const validateEmail = (email) => { | |||
| return email.match( | |||
| /^(?=.{1,254}$)(?=.{1,64}@)[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+)*@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/ | |||
| /^(?=.{1,254}$)(?=.{1,64}@)[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+(?:\.[a-zA-Z0-9!#$%&'*+/=?^_`{|}~-]+)*@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/, | |||
Member
There was a problem hiding this comment.
Why does this add a comma to the end?
| @@ -22,11 +22,16 @@ function Example() { | |||
| <IonText color="warning"> | |||
| <IonIcon icon={warning}></IonIcon> | |||
| </IonText> | |||
| I saw a werewolf with a Chinese menu in his hand. Walking through the <IonText color="success"> | |||
| I saw a werewolf with a Chinese menu in his hand. Walking through the{' '} | |||
Member
There was a problem hiding this comment.
Can we remove these spaces?
Suggested change
| I saw a werewolf with a Chinese menu in his hand. Walking through the{' '} | |
| I saw a werewolf with a Chinese menu in his hand. Walking through the |
| <sub>streets</sub> | ||
| </IonText> of Soho in the rain. He <IonText color="medium"> | ||
| </IonText>{' '} |
Member
There was a problem hiding this comment.
Suggested change
| </IonText>{' '} | |
| </IonText> |
| <sub>streets</sub> | ||
| </IonText> of Soho in the rain. He <IonText color="medium"> | ||
| </IonText>{' '} | ||
| of Soho in the rain. He{' '} |
Member
There was a problem hiding this comment.
Suggested change
| of Soho in the rain. He{' '} | |
| of Soho in the rain. He |
| <i>was</i> | ||
| </IonText> looking for a place called Lee Ho Fook's. Gonna get a <IonText color="danger">big dish of beef chow mein.</IonText> | ||
| </IonText>{' '} |
Member
There was a problem hiding this comment.
Suggested change
| </IonText>{' '} | |
| </IonText> |
| <i>was</i> | ||
| </IonText> looking for a place called Lee Ho Fook's. Gonna get a <IonText color="danger">big dish of beef chow mein.</IonText> | ||
| </IonText>{' '} | ||
| looking for a place called Lee Ho Fook's. Gonna get a{' '} |
Member
There was a problem hiding this comment.
Suggested change
| looking for a place called Lee Ho Fook's. Gonna get a{' '} | |
| looking for a place called Lee Ho Fook's. Gonna get a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Prettier is on 2.8.8, released in 2023.
@ionic/prettier-configis on v3.What is the new behavior?
@ionic/prettier-configv4<strong>,<b>,<em>,<i>) to markdown indocs/andversioned_docs/version-v8Does this introduce a breaking change?
Other information
1009 files, but almost all of it is one line each. The breakdown:
<!DOCTYPE html>→<!doctype html>. Prettier 3 lowercases it. Browsers don't care@ionic/prettier-configv4, whose only change istrailingComma: 'es5'→'all'. That adds commas after function parameters, which then breaks long signatures one-per-line. Mostly Angular constructor injection in code samplesWhy the HTML conversion is here. Raw HTML in a markdown paragraph makes prettier treat it as JSX and hard-wrap the prose at 120 chars, splitting sentences mid-line. Prettier 3 made that more visible, so converting to
**removes the cause. Bold and italics render identically.