Skip to content

chore(docs): use markdown syntax for external links - #4667

Merged
thetaPC merged 10 commits into
mainfrom
external-links
Aug 27, 2026
Merged

chore(docs): use markdown syntax for external links#4667
thetaPC merged 10 commits into
mainfrom
external-links

Conversation

@thetaPC

@thetaPC thetaPC commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Issue URL: N/A

What is the current behavior?

External links are written two ways: mostly markdown, but 338 as raw <a target="_blank">. 198 of those are missing rel="noopener noreferrer".

The glossary is built from 41 <section> blocks with raw anchors, which prettier mangles into invalid HTML. So both glossaries sit in .prettierignore, and index.md needs a prettier-ignore.

Those anchors are HTML id attributes, not heading IDs, so Docusaurus can't validate them. 195 broken anchor references went unchecked, including a [Babel](#babel) link with no Babel entry.

What is the new behavior?

  • 338 raw anchors converted to markdown links
  • Both glossaries rewritten as markdown headings (### Term {/* #id */}), all 41 IDs preserved
  • Babel entry added, fixing the dead anchor
  • Both prettier exclusions removed

Left alone: 3 anchors that wrap markup, and 7 inside code fences.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Readers see no difference. Docusaurus already adds target="_blank" rel="noopener noreferrer" to external URLs, so markdown links render the same as the raw ones did.

Wins:

  • 198 links gain rel="noopener noreferrer", closing a window.opener gap
  • Broken glossary anchors: 195 → 0, now that Docusaurus can validate them
  • Glossary gets a table of contents (42 terms), since raw <h3> is invisible to it

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-docs Ready Ready Preview Aug 27, 2026 3:28pm

Request Review

@thetaPC
thetaPC marked this pull request as ready for review August 26, 2026 18:10
@thetaPC
thetaPC requested a review from a team as a code owner August 26, 2026 18:10
@thetaPC
thetaPC requested a review from ShaneK August 26, 2026 18:10
Comment thread docs/theming/advanced.md
Comment thread versioned_docs/version-v8/theming/advanced.md
Comment thread docs/reference/glossary.md Outdated
Comment thread docs/reference/glossary.md Outdated
Comment thread docs/reference/glossary.md Outdated
Comment thread docs/reference/glossary.md
thetaPC and others added 2 commits August 26, 2026 15:15
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>

@brandyscarney brandyscarney left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more requested changes then it looks good!

Comment thread docs/reference/glossary.md Outdated
Comment thread versioned_docs/version-v7/reference/glossary.md Outdated
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
@thetaPC
thetaPC merged commit 54fe46e into main Aug 27, 2026
4 checks passed
@thetaPC
thetaPC deleted the external-links branch August 27, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants