fix(ui): prevent disabled hotkeys from blocking shared keys - #9569
Open
DustyShoe wants to merge 1 commit into
Open
fix(ui): prevent disabled hotkeys from blocking shared keys#9569DustyShoe wants to merge 1 commit into
DustyShoe wants to merge 1 commit into
Conversation
DustyShoe
marked this pull request as ready for review
September 4, 2026 14:23
DustyShoe
requested review from
JPPhoto,
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
September 4, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9482.
The Canvas eyedropper and Viewer metadata panel both use
I. Disabled hotkeys were wrapped in anenabledcallback, causingreact-hotkeys-hookto keep their listeners registered. A disabled listener could then block the active handler for the same key.This keeps
enabled: falsestatic so disabled hotkeys are not registered, while preserving the Canvas Text session guard and custom predicates.Expected behavior
Clicking a gallery thumbnail moves focus to Gallery, so
Idoes not toggle Viewer metadata until Viewer regains focus.Navigating between images with the arrow keys keeps focus in Viewer, so
Icontinues to toggle metadata.Related Issues / Discussions
Re-Closes #9467
QA Instructions
Iselects the eyedropper.Zand confirmItoggles metadata.Checklist
What's Newcopy (if doing a release after this PR)