Skip to content

Import all no longer deletes mapped items - #1004

Merged
isc-pbarton merged 1 commit into
mainfrom
dont-delete-mapped
Sep 3, 2026
Merged

Import all no longer deletes mapped items#1004
isc-pbarton merged 1 commit into
mainfrom
dont-delete-mapped

Conversation

@isc-pbarton

Copy link
Copy Markdown
Collaborator

Description

Fixes #997
A more general approach is in #1003 but I'm unsure if we want it. Skipping deletion of mapped items on import is a more targeted and less risky fix to the major bug in #997.

Testing

Unit test covers the scenario in the bug report

Checklist

  • This branch has the latest changes from the main branch rebased or merged.
  • [N/A] Web UI has been built (any changes in git-webui/src have matching changes in git-webui/release)
  • CHANGELOG.md entry added if appropriate.
  • [N/A] Documentation has been/will be updated

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.95%. Comparing base (0290792) to head (4203052).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   49.92%   49.95%   +0.02%     
==========================================
  Files          23       23              
  Lines        3373     3375       +2     
==========================================
+ Hits         1684     1686       +2     
  Misses       1689     1689              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton
isc-pbarton merged commit 14ca955 into main Sep 3, 2026
2 checks passed
@isc-pbarton
isc-pbarton deleted the dont-delete-mapped branch September 3, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded Git deletes itself on import

3 participants