Fix docker-compose connections always prompting for password - #1860
Draft
isc-klu wants to merge 17 commits into
Draft
Fix docker-compose connections always prompting for password#1860isc-klu wants to merge 17 commits into
isc-klu wants to merge 17 commits into
Conversation
resolveConnectionSpec's docker-compose branch built connSpec.auth as an empty BasicAuthorization(), discarding the plaintext password already resolved by serverForUri from objectscript.conn.password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveConnectionSpec's docker-compose branch builtconnSpec.authas an emptynew BasicAuthorization(), discarding the plaintext password already resolved byserverForUrifromobjectscript.conn.password. This leftconnSpec.auth.resolved()false, sending the connection through the password-prompt/resolution path on every use instead of using the configured credentials.serverForUri.auth(already resolved) instead.Fixes #1858.
Test plan
objectscript.conn.passworddirectly (nointersystems.servers); confirmed the "Authorization error" / repeated prompting before the fix.