Fix broken Marketplace badges, drop superfluous ones in README - #1857
Open
isc-klu wants to merge 18 commits into
Open
Fix broken Marketplace badges, drop superfluous ones in README#1857isc-klu wants to merge 18 commits into
isc-klu wants to merge 18 commits into
Conversation
isc-klu
changed the title
shields.io retired its visual-studio-marketplace badge category (both now render "retired badge"); switch to vsmarketplacebadges.dev, which queries the Marketplace API directly. Also drop the Snyk badge and the redundant Caché/Ensemble badges, which now all link to the same InterSystems IRIS product page.
The legacy `vsce` package's last published version (2.15.0, which npx resolves to since the package is no longer updated) hardcodes an SVG badge-host allowlist that only trusts the now-dead vsmarketplacebadge.apphb.com, not its replacement vsmarketplacebadges.dev. @vscode/vsce is the actively maintained successor and already trusts vsmarketplacebadges.dev.
isc-klu
marked this pull request as ready for review
September 4, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visual-studio-marketplacebadge category (both badges rendered "retired badge"). Switched tovsmarketplacebadges.dev, which still returns live version/install data.vsceto@vscode/vsce:npx vsceresolves tovsce@2.15.0, whose SVG-host allowlist doesn't includevsmarketplacebadges.devand rejected the build;@vscode/vscedoes.Fixes #1853.
Test plan
npx @vscode/vsce packagesucceeds locally (previously failed on README SVG validation).