fix: lint the artifact scorer — import order and line length - #200
Merged
Conversation
added 2 commits
September 7, 2026 02:57
The three ara-diac-small-2.1 metadata files quote the E4 result in trained_from; the quoted 4.8218/42% figures were withdrawn on 2026-09-05 (RESULTS.md CORRECTION: corrected 2.0 number is 5.08, 38% reduction) - now restated with the correction inline. PUBLICATION-NOTES lever table and epoch sentence move to the corrected control; the E5 line keeps its original measurement with the control correction noted. EXPERIMENTS: the E4 verdict keeps its historical figure with the correction annotation, and the GKD verdict line (written 2026-09-06, post- correction, but still citing +1.18pp over 4.8218) restates the delta as +1.43pp over the 4.5701 rung it was meant to improve. Metrics values are untouched - only prose.
The artifact-level scoring tool landed with an unsorted import block (I001) and a 101-char line (E501), turning main's test job red and failing every open PR against it. Ruff --fix reordered the block (interscript_ml classifies third-party, grouping with pandas); the long preds-write line split. Unblocks main and the correction PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main's test job is red since the artifact-level scorer landed: ruff I001 (unsorted import block —
interscript_mlclassifies third-party, grouping with pandas) and one E501 (101 chars). Every open PR against the repo inherits the failure, including the correction-propagation PR #199.Fix: ruff --fix for the import order; the long preds-write line split.
ruff checkclean, syntax-checked. No behavior change — imports inside a Modal function body, order irrelevant to execution.