fix(parity): stage completeness = zip parity block + margins json - #160
Merged
Conversation
…ns json The layerdrop chain skipped int4 because yesterday's standalone margin_model run had written margins-int4.json — but margin_model never writes the zip's parity block, so the int4 zip shipped parity-less and would fail the strict validator. pending_precisions now requires both markers; corrupt or missing zips are pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live failure today: the layerdrop parity chain skipped the int4 stage
because margins-int4.json existed — written by a standalone
margin_model run, which never writes the zip's parity block. The int4
zip (the browser-budget artifact) was left parity-less and would have
failed the strict validator at publish time.
What
pending_precisionsrequires BOTH the margins report and a parityblock inside
{mid}-{precision}.zip's metadata. Missing/corrupt zipscount as pending. 3 new tests (margins-without-parity reruns;
both-present skips; corrupt zip pending); 2 existing tests updated to
the tightened contract. Full suite: 127 passed.