WEBDEV-9256: Fix the demo focused-view test that fails in CI - #138
Merged
Merged
Conversation
Loading <ia-button-story> is a lazy dynamic import, and a busy CI runner can take more than the default 1-second waitUntil timeout to finish it. Other waits on lazy-loaded story content in this file already carry a 5000ms timeout for the same reason; this one never got the same bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 91.23% 91.43% +0.20%
==========================================
Files 60 60
Lines 2520 2627 +107
Branches 583 614 +31
==========================================
+ Hits 2299 2402 +103
Misses 77 77
- Partials 144 148 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://webarchive.jira.com/browse/WEBDEV-9256
The focused-view story-load test only gives itself the default 1s waitUntil timeout for a lazy dynamic import, which a busy CI runner can take longer than. Bumped it to 5000ms, matching the other story-load waits in the same file.
🤖 Generated with Claude Code