Conversation
Covers disconnectedCallback, which was the only uncovered code in the component. Both leak fixes from #84 now have a test: one checks the pending autoscroll-resume timer is dropped, the other that the scroll animation is cancelled. Deleting either cleanup fails its test. Drops isClickable. It was set and reflected but nothing read it, there was no [isclickable] selector, and cursor: pointer applies unconditionally. Nothing in the repo or in offshoot touches ia-transcript-entry, so it changes nothing at runtime. Adds the missing colour vars to the story's Styles table. The four music-* ones were the reported gap; the two auto-scroll-button colours had the same problem, so recolouring the demo left that button black-on-white with no way to reach it. The size-only vars stay out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JpyQxVSkZFrWxxGamCcNhY
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 85.79% 85.79% -0.01%
==========================================
Files 74 74
Lines 2619 2618 -1
Branches 577 577
==========================================
- Hits 2247 2246 -1
Misses 195 195
Partials 177 177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neeraj's three nits from #84 (WEBDEV-8968), split out so they didn't hold up the radio player release.
disconnectedCallbackwas the component's only uncovered code, so both leak fixes that PR made were untested. Two tests now cover them.isClickablewas set and reflected but nothing read it, so it's gone. No consumer touchesia-transcript-entry, so nothing changes at runtime.music-*vars. Added those, plus the two auto-scroll-button colours which had the same problem.QA waived, no runtime change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JpyQxVSkZFrWxxGamCcNhY