Repository navigation
fix: give the macOS leg a 70-minute ceiling, warning at 60 - #1103
Merged
Merged
Conversation
Ten merge-group runs on 2026-10-18 took the check job's macOS leg 35.1 to 49.3 minutes, one within a minute of its 50-minute warning. Its one race pass keeps a steady 2.80 to 2.85 of the runner's three test slots busy, so the leg is its total work, not one long package, and that work varies with the runner: the same tree's package times summed to 5,738 to 8,050 seconds. The coordinating session, on delegation from the technical facilitator, raised the ceiling to 70 and the warning to 60 (dcn-2610181756328249), still under the merge queue's 90-minute response timeout and with the warning's ten-minute lead. The warning's message names the cap from its own line and that lead, so it no longer says 60 whatever the ceiling. Unchanged, and why: the per-package -timeout of 40 minutes, since the slowest package took at most 31.7 under race; and release.yml's verify job, which runs the ubuntu race lane, about 21 minutes, under its own 55. The pass's total work is the longer lever, captured with the package-wide figure: the claim changes cut one drain test's git processes by a quarter but the loop and claim packages' by 5.5%, which the loop-speed record's Outcome now says. Resolves: iss-2610181711260494 Refs: iss-2610181757540736 Refs: iss-2610180545134593 Assisted-by: Claude:claude-opus-5-5
Review notes on the ceiling change. The warning's message named the cap as its warning line plus ten, a second copy of the lead no test read, so a changed lead would leave the tests green and the message naming a cap the job does not have. The step now carries CEILING_MINUTES, the message names the cap from it, and the test holds it to the leg's ceiling. The decision said the loop package ends 3 to 4 minutes before the pass, where the runs give 2.5 to 4.2, and that one run came within 0.7 minutes of the warning, now the old 50-minute one; a ci.yml comment still called the ceiling 60. Refs: iss-2610181711260494 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The check job's macOS leg gets a 70-minute ceiling, with its warning at 60, up from 60 and 50. The coordinating session decided this on delegation from the technical facilitator (dcn-2610181756328249).
Why. Ten merge-group runs on 2026-10-18:
Times are in minutes unless marked. One run came within 0.7 minutes of the old 50-minute warning.
internal/core/implement/loopstarts 8 to 12 minutes in and ends 2.5 to 4.2 minutes before the pass does.The warning message. It named the cap as its warning line plus ten, a second copy of the lead that no test read. The step now carries
CEILING_MINUTES, the message names the cap from it, andTestCheckJobWarnsBeforeTheQueueCapholds it to the leg's ceiling. There is still no${{ }}insiderun:.Unchanged, and why:
-timeoutof 40 minutes: the slowest package under race took at most 1,901 seconds (31.7 minutes), a margin of 8.3.release.yml's verify job: it runs the ubuntu race lane over./internal/..., about 21 minutes, under its own 55-minute ceiling, not this pass.Records.
Evidence
TestRaceLaneBudgetIsDeclaredAndFitsItsJobandTestCheckJobWarnsBeforeTheQueueCapfailed before the ci.yml edit and pass after it. TheCEILING_MINUTESpin was watched failing before the step carried it.bash -ewith the step's values.make preflightpassed on this commit (receipt minted).ci.ymlis on the CODEOWNERS publish surface: both LAND. They checked the expression, the test pin, zizmor's template-injection rule and the decision's numbers against the table. Their notes are applied in the second commit.Resolves: iss-2610181711260494
Refs: iss-2610181757540736
Refs: iss-2610180545134593
Assisted-by: Claude:claude-opus-5-5