Repository navigation
Rewrote to_register utility - #41
Open
danieltowner wants to merge 1 commit into
Open
danieltowner wants to merge 1 commit into
danieltowner wants to merge 1 commit into
Conversation
Previously `to_register` would return a builtin with enough elements to fill a complete register of the appropriate size, but this often wouldn't be allowed as a parameter to an intrinsic. The new version converts the register type to the one of the common intrinsic types (e.g., __m256i, __m512d, __m128h). This simplifies intrinsic calls by allowing `to_register` to handle the type conversion without also requiring an explicit cast at the intrinsic call site. This work is an important step in eliminating the use of `flax-vector-conversions` since it allows intrinsic calls without implicit conversions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
to_registerwould return a builtin with enough elements to fill a complete register of the appropriate size, but this often wouldn't be allowed as a parameter to an intrinsic. The new version converts the register type to the one of the common intrinsic types (e.g., __m256i, __m512d, __m128h). This simplifies intrinsic calls by allowingto_registerto handle the type conversion without also requiring an explicit cast at the intrinsic call site.This work is an important step in eliminating the use of
flax-vector-conversionssince it allows intrinsic calls without implicit conversions.