feat(INSTUI-5156): new skeleton loader - #2720
HouseOfHawks wants to merge 1 commit into
Conversation
fix(INSTUI-5156): deleted ssr-lab fix(INSTUI-5157): cleanup
|
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (33)alert-canvas.png — 2507 pixels differalert-dark.png — 50924 pixels differalert-light.png — 24123 pixels differavatar-dark.png — 107 pixels differavatar-light.png — 107 pixels differbadge-canvas.png — 1573 pixels differbillboard-dark.png — 36899 pixels differbillboard-light.png — 36841 pixels differcolorpicker-canvas.png — 316 pixels differcolorpicker-dark.png — 53664 pixels differcolorpicker-light.png — 41507 pixels differcustom-icons-canvas.png — 565 pixels differcustom-icons-dark.png — 498 pixels differcustom-icons-light.png — 594 pixels differdrilldown-canvas.png — 130 pixels differdrilldown-dark.png — 1572 pixels differdrilldown-light.png — 986 pixels differfiledrop-dark.png — 6892 pixels differfiledrop-light.png — 6957 pixels differheading-dark.png — 27544 pixels differheading-light.png — 27459 pixels differprogressbar-canvas.png — 1661 pixels differprogressbar-dark.png — 1672 pixels differprogressbar-light.png — 1661 pixels differsmall-components-canvas.png — 1968 pixels differsmall-components-dark.png — 10747 pixels differsmall-components-light.png — 6350 pixels differtooltip-canvas.png — 65 pixels differtooltip-dark.png — 109740 pixels differtooltip-light.png — 102371 pixels differview-canvas.png — 1088 pixels differview-dark.png — 2112 pixels differview-light.png — 2112 pixels differBaselines come from the |
| themeOverride={{ | ||
| background: '#BF32A4', | ||
| color: 'white', | ||
| // v1.10.0 replaced Alert's single `background` token with |
There was a problem hiding this comment.
What is v1.10.0? And what has this to do with skeleton loaders?
There was a problem hiding this comment.
instructure-design-tokens update with the Skeleton tokens
There was a problem hiding this comment.
That should be v1.9.0, though: https://github.com/instructure/instructure-design-tokens/pull/17/changes
There was a problem hiding this comment.
Either way, this is more of a placeholder until the tokens work is shipped. Will be removed.
2 participants
This PR:
useIsHydratedcontext provider inui-react-utils<SkeletonLoader>component and<SkeletonShape>sub-component