Conversation
…s reliable Folders for closed PRs piled up on gh-pages (3.1 GB checkout, 121 stale folders) because the event-based cleanup lost in several ways: push races between the two close-event jobs, a repo-wide concurrency group that cancelled queued runs, and slow deploys finishing after the removal and re-creating the folder. - Add gh-pages-dir.sh: replaces or removes one directory on gh-pages, retrying from a fresh shallow fetch when the push is rejected - visual-regression: per-PR concurrency group with cancel-in-progress, publish and cleanup both go through the script, cleanup no longer clones the full gh-pages history - preview: cancel-in-progress so a close run cancels an in-flight deploy 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (1)badge-canvas.png — 1573 pixels differBaselines come from the |
The daily cleanup in gh-pages-cleanup.yml (PR #2719) owns removal of closed-PR folders, so the close-event cleanup job and the retrying push script are not needed. What remains fixes a different bug: the repo-wide `gh-pages` concurrency group cancelled other PRs' queued visual-regression runs, so those PRs got no report for that commit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
matyasf
changed the title
matyasf
commented
Sep 16, 2026
| if: steps.diff.outcome == 'failure' || steps.cypress.outcome == 'failure' | ||
| run: exit 1 | ||
|
|
||
| cleanup-report: |
Collaborator
Author
There was a problem hiding this comment.
The left lots of reports still in the repo. A daily job does now this much better: #2719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh-pagesconcurrency group with one group per PR andcancel-in-progress. The shared group cancelled other PRs' queued runs (8 of the last 12 cancellations), so those PRs got no report for that commitclosedtrigger and the cleanup job; removal of closed-PR folders moves to the daily cleanup in ci: add a daily cleanup of the gh-pages previews #2719cancel-in-progressso a newer push cancels a deploy still running for an older commitTest Plan
Fixes INSTUI-5192
🤖 Generated with Claude Code